Run method without done function parameter

[marcospds]

The method run receive done function, for finish the gulp task after run task list.
Create a method run without done function parameter, allowed finish the gulp task before the list.

Actual:

gulp.task('e2e:*', (done) => {
  TaskListRun.run(gulp, 'e2e:*', 'e2e:\\*', done)
})

//Starting 'e2e:*'...
//Starting 'e2e:login'...
//It works e2e:login!
//Finished 'e2e:login' after 745 μs
//Starting 'e2e:demo'...
//It works e2e:demo!
//Finished 'e2e:demo' after 339 μs
//Starting 'finish_e2e:*'...
//Finished 'finish_e2e:*' after 263 μs
//Finished 'e2e:*' after 2.7 ms

Expected:

gulp.task('e2e:*', (done) => {
  TaskListRun.run(gulp, 'e2e:*', 'e2e:\\*', done)
})

//Starting 'e2e:*'...
//Starting 'e2e:login'...
//It works e2e:login!
//Finished 'e2e:login' after 745 μs
//Starting 'e2e:demo'...
//It works e2e:demo!
//Finished 'e2e:demo' after 339 μs
//Starting 'finish_e2e:*'...
//Finished 'finish_e2e:*' after 263 μs
//Finished 'e2e:*' after 2.7 ms

Or

gulp.task('e2e:*', (done) => {
  TaskListRun.run(gulp, 'e2e:*', 'e2e:\\*')
  done()
})

//Starting 'e2e:*'...
//Finished 'e2e:*' after 722 μs
//Starting 'e2e:login'...
//It works e2e:login!
//Finished 'e2e:login' after 745 μs
//Starting 'e2e:demo'...
//It works e2e:demo!
//Finished 'e2e:demo' after 339 μs

[Jayaram18]

Can you please elaborate on the expectation ? I could see same code in expected. I also would like to understand the order of execution in the expectation.

[marcospds]

Hello @Jayaram18, the idea is not to break the current call by passing the parameter function done, basically it is to make the parameter function done optional. That's why in the expectation you have both.