Merge pull request #13 from marcosschroh/fix/add-missing-tests

feat: Some missing tests added.

Author: marcosschroh

.flake8

@@ -0,0 +1,3 @@
+[flake8]
+exclude = .git,__pycache__,docs/source/build,dist
+max-line-length = 100

docs/client.md

@@ -130,7 +130,8 @@ def get_compatibility(subject, headers=None):
         headers (dict): Extra headers to add on the requests
 
     Returns:
-        str: one of 'NONE','FULL','FORWARD', or 'BACKWARD'
+        str: one of BACKWARD, BACKWARD_TRANSITIVE, FORWARD, FORWARD_TRANSITIVE,
+            FULL, FULL_TRANSITIVE, NONE
 
     Raises:
         ClientError: if the request was unsuccessful or an invalid
@@ -144,9 +145,11 @@ def get_compatibility(subject, headers=None):
 def update_compatibility(level, subject, headers=None):
     """
     Update the compatibility level for a subject.
+    If subject is None, the compatibility level is global.
 
     Args:
-        level (str): ex: 'NONE','FULL','FORWARD', or 'BACKWARD'
+        level (str): one of BACKWARD, BACKWARD_TRANSITIVE, FORWARD, FORWARD_TRANSITIVE,
+            FULL, FULL_TRANSITIVE, NONE
         headers (dict): Extra headers to add on the requests
 
     Returns:

schema_registry/client/client.py

@@ -189,7 +189,7 @@ def register(self, subject, avro_schema, headers=None):
             msg = "Unable to register schema"
 
         if msg is not None:
-            raise ClientError(message=msg, code=code, server_traceback=result)
+            raise ClientError(message=msg, http_code=code, server_traceback=result)
 
         schema_id = result["id"]
         self._cache_schema(avro_schema, schema_id, subject)
@@ -214,7 +214,9 @@ def delete_subject(self, subject, headers=None):
 
         result, code = self.request(url, method="DELETE", headers=headers)
         if not (status.HTTP_200_OK <= code < status.HTTP_300_MULTIPLE_CHOICES):
-            raise ClientError("Unable to delete subject", code, server_traceback=result)
+            raise ClientError(
+                "Unable to delete subject", http_code=code, server_traceback=result
+            )
         return result
 
     def get_by_id(self, schema_id, headers=None):
@@ -252,7 +254,7 @@ def get_by_id(self, schema_id, headers=None):
                 # bad schema - should not happen
                 raise ClientError(
                     f"Received bad schema (id {schema_id})",
-                    code,
+                    http_code=code,
                     server_traceback=result,
                 )
 
@@ -365,7 +367,9 @@ def test_compatibility(self, subject, avro_schema, version="latest", headers=Non
             elif status.HTTP_200_OK <= code < status.HTTP_300_MULTIPLE_CHOICES:
                 return result.get("is_compatible")
             else:
-                log.error(f"Unable to check the compatibility: {code}")
+                log.error(
+                    f"Unable to check the compatibility: {code}. Traceback: {result}"
+                )
                 return False
         except Exception as e:
             log.error(f"request() failed: {e}")
@@ -374,10 +378,13 @@ def test_compatibility(self, subject, avro_schema, version="latest", headers=Non
     def update_compatibility(self, level, subject=None, headers=None):
         """
         PUT /config/(string: subject)
-        Update the compatibility level for a subject. Level must be one of:
+        Update the compatibility level.
+        If subject is None, the compatibility level is global.
 
         Args:
-            level (str): ex: 'NONE','FULL','FORWARD', or 'BACKWARD'
+            level (str): one of BACKWARD, BACKWARD_TRANSITIVE, FORWARD, FORWARD_TRANSITIVE,
+                FULL, FULL_TRANSITIVE, NONE
+            subject (str): Option subject
             headers (dict): Extra headers to add on the requests
 
         Returns:
@@ -394,8 +401,10 @@ def update_compatibility(self, level, subject=None, headers=None):
         result, code = self.request(url, method="PUT", body=body, headers=headers)
         if status.HTTP_200_OK <= code < status.HTTP_300_MULTIPLE_CHOICES:
             return result["compatibility"]
-        else:
-            raise ClientError(f"Unable to update level: {level}. Error code: {code}")
+
+        raise ClientError(
+            f"Unable to update level: {level}.", http_code=code, server_traceback=result
+        )
 
     def get_compatibility(self, subject, headers=None):
         """
@@ -406,8 +415,8 @@ def get_compatibility(self, subject, headers=None):
             headers (dict): Extra headers to add on the requests
 
         Returns:
-            str: one of 'NONE','FULL','FORWARD', or 'BACKWARD'
-
+            str: one of BACKWARD, BACKWARD_TRANSITIVE, FORWARD, FORWARD_TRANSITIVE,
+                FULL, FULL_TRANSITIVE, NONE
         Raises:
             ClientError: if the request was unsuccessful or an invalid
             compatibility level was returned
@@ -421,9 +430,7 @@ def get_compatibility(self, subject, headers=None):
             status.HTTP_200_OK <= code < status.HTTP_300_MULTIPLE_CHOICES
         )
         if not is_successful_request:
-            raise ClientError(
-                f"Unable to fetch compatibility level. Error code: {code}"
-            )
+            raise ClientError(f"Unable to fetch compatibility level")
 
         compatibility = result.get("compatibilityLevel")
         if compatibility not in utils.VALID_LEVELS:
@@ -433,7 +440,7 @@ def get_compatibility(self, subject, headers=None):
                 error_msg_suffix = str(compatibility)
             raise ClientError(
                 f"Invalid compatibility level received: {error_msg_suffix}",
-                code,
+                http_code=code,
                 server_traceback=result,
             )
 

tests/client/test_http_client.py

@@ -85,10 +85,6 @@ def test_getters(client):
     assert fetched == parsed
 
 
-# def test_schema_compatibility(client):
-#     adv = load.loads(data_gen.ADVANCED_SCHEMA)
-
-
 def test_multi_register(client):
     """
     Register two different schemas under the same subject
@@ -117,6 +113,40 @@ def test_multi_register(client):
     assert latest_schema_2 == latest_schema_3
 
 
+def test_compatibility(client, user_schema_v3):
+    """
+    Test the compatibility of a new User Schema against the latest one.
+    The last user schema is the V2.
+    """
+    compatibility = client.test_compatibility("test-user-schema", user_schema_v3)
+    assert compatibility
+
+
+def test_update_compatibility(client):
+    """
+    The latest User V2 schema is  BACKWARD and FORWARDFULL compatibility (FULL).
+    So, we can ipdate compatibility level for the specified subject.
+    """
+    assert client.update_compatibility("FULL", "test-user-schema") == "FULL"
+
+
+def test_get_compatibility(client):
+    """
+    Test latest compatibility for test-user-schema subject
+    """
+    assert client.get_compatibility("test-user-schema") == "FULL"
+
+
+def test_delete_subject(client, user_schema_v3):
+    subject = "subject-to-delete"
+    versions = [load.loads(data_gen.USER_V1), load.loads(data_gen.USER_V2)]
+
+    for version in versions:
+        client.register(subject, version)
+
+    assert client.delete_subject(subject) == [1, 2]
+
+
 def test_context(client):
     with client as c:
         parsed = load.loads(data_gen.BASIC_SCHEMA)

tests/client/test_util.py tests/client/test_load.pytests/client/test_util.py renamed to tests/client/test_load.py

@@ -41,6 +41,40 @@ def country_schema():
     )
 
 
+@pytest.fixture
+def user_schema_v3():
+    """
+    The user V2 is:
+    {
+        "type": "record",
+        "name": "User",
+        "aliases": ["UserKey"],
+        "fields": [
+            {"name": "name", "type": "string"},
+            {"name": "favorite_number",  "type": ["int", "null"], "default": 42},
+            {"name": "favorite_color", "type": ["string", "null"], "default": "purple"}
+        ]
+    }
+    """
+    return SchemaFromJSONData(
+        {
+            "type": "record",
+            "name": "User",
+            "aliases": ["UserKey"],
+            "fields": [
+                {"name": "name", "type": "string"},
+                {"name": "favorite_number", "type": ["int", "null"], "default": 42},
+                {
+                    "name": "favorite_color",
+                    "type": ["string", "null"],
+                    "default": "purple",
+                },
+                {"name": "country", "type": ["null", "string"], "default": None},
+            ],
+        }
+    )
+
+
 @pytest.fixture
 def message_serializer(client):
     return MessageSerializer(client)