Linting fixes with phpbf

Author: marcusgreen

classes/external/check_feedback_status.php

@@ -42,8 +42,12 @@ class check_feedback_status extends external_api {
     public static function execute_parameters(): external_function_parameters {
         return new external_function_parameters([
             'assignmentid' => new external_value(PARAM_INT, 'The assignment instance id'),
-            'userid' => new external_value(PARAM_INT, 'The user id to check feedback for, 0 to check all pending tasks',
-                VALUE_DEFAULT, 0),
+            'userid' => new external_value(
+                PARAM_INT,
+                'The user id to check feedback for, 0 to check all pending tasks',
+                VALUE_DEFAULT,
+                0
+            ),
         ]);
     }
 
@@ -73,7 +77,7 @@ public static function execute(int $assignmentid, int $userid = 0): array {
 
         if ($params['userid'] > 0) {
             // Per-user mode: check if feedback exists for a specific user.
-            $canview = ($params['userid'] == $GLOBALS['USER']->id)
+            $canview = ($params['userid'] == $globals['USER']->id)
                 || has_capability('mod/assign:grade', $context);
             if (!$canview) {
                 throw new \required_capability_exception($context, 'mod/assign:grade', 'nopermissions', '');
@@ -105,7 +109,7 @@ public static function execute(int $assignmentid, int $userid = 0): array {
             'pattern' => '%"assignment":' . $params['assignmentid'] . '%',
         ]);
 
-        // feedbackexists=true means "done" (no more pending tasks).
+        // The feedbackexists=true item means "done" (no more pending tasks).
         return ['feedbackexists' => !$pending];
     }
 

classes/task/process_feedback_adhoc.php

@@ -90,7 +90,7 @@ private function get_submission_record(int $assignmentid, int $userid) {
      *
      * @param object|false $record The submission record.
      * @param string $triggeredby How the task was triggered: 'auto' (observer) or 'manual' (teacher).
-     * @param \assign $assign The assign instance.
+     * @param \assign|null $assign The assign instance.
      */
     private function generate_feedback($record, string $triggeredby = 'manual', ?\assign $assign = null): void {
         global $DB, $CFG;

locallib.php

@@ -68,7 +68,7 @@ public function get_editor_options(): array {
      */
     public function get_settings(MoodleQuickForm $mform): void {
 
-        // ai_manager infobox: data sharing notice for teachers configuring the prompt.
+        // AI manager infobox: data sharing notice for teachers configuring the prompt.
         if (get_config('assignfeedback_aif', 'backend') === 'local_ai_manager') {
             global $PAGE, $USER;
             $mform->addElement('html', '<div data-aif="aisettingsinfo"></div>');
@@ -236,7 +236,7 @@ public function set_editor_text($name, $value, $gradeid): bool {
     public function get_form_elements_for_user($grade, MoodleQuickForm $mform, stdClass $data, $userid): bool {
         global $PAGE, $USER;
 
-        // ai_manager widgets: infobox (data sharing notice) and quota.
+        // AI manager widgets: infobox (data sharing notice) and quota.
         if (get_config('assignfeedback_aif', 'backend') === 'local_ai_manager') {
             $mform->addElement('html', '<div data-aif="aiinfo"></div>');
             $mform->addElement('html', '<div data-aif="aiuserquota" class="mb-2"></div>');