MBS-10583: Fixes after CR

Author: PM84

amd/build/regenerate.min.js

@@ -24,6 +24,7 @@
 
 import Ajax from 'core/ajax';
 import Notification from 'core/notification';
+import {add as addToast} from 'core/toast';
 import {get_string as getString} from 'core/str';
 import Pending from 'core/pending';
 
@@ -64,15 +65,9 @@ export const init = (assignmentId, userId) => {
             }])[0];
 
             if (result.success) {
-                Notification.addNotification({
-                    message: result.message,
-                    type: 'success',
-                });
+                addToast(result.message, {type: 'success'});
             } else {
-                Notification.addNotification({
-                    message: result.message,
-                    type: 'error',
-                });
+                addToast(result.message, {type: 'danger'});
             }
         } catch (error) {
             Notification.exception(error);

amd/build/regenerate.min.js.map

@@ -28,7 +28,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class aif {
-    /** @var int The context ID for AI requests. */
     /** @var int The context ID for AI requests. */
     protected int $contextid;
 
@@ -48,7 +47,7 @@ public function __construct(int $contextid) {
      * via \core\di::set(ai_request_provider::class, $mock).
      *
      * @param string $prompt The prompt to send to the AI.
-     * @param string|null $purpose The purpose of the request (for local_ai_manager). If null, uses config.
+     * @param string|null $purpose The purpose of the request (for local_ai_manager). Defaults to 'feedback'.
      * @param array $options Additional options (e.g., 'image' for ITT requests).
      * @param int $userid The user to attribute the AI request to. Defaults to current $USER.
      * @return string The AI response.
@@ -62,9 +61,8 @@ public function perform_request(string $prompt, ?string $purpose = null, array $
 
         $provider = \core\di::get(ai_request_provider::class);
 
-        // Get purpose from config if not provided.
         if ($purpose === null) {
-            $purpose = get_config('assignfeedback_aif', 'purpose') ?: 'feedback';
+            $purpose = 'feedback';
         }
 
         $backend = get_config('assignfeedback_aif', 'backend') ?: 'core_ai_subsystem';

amd/src/regenerate.js

@@ -16,7 +16,7 @@
 
 namespace assignfeedback_aif\event;
 
-use assignfeedback_aif\task\process_feedback_rubric_adhoc;
+use assignfeedback_aif\task\process_feedback_adhoc;
 use core\task\manager;
 
 /**
@@ -59,14 +59,15 @@ private static function queue_feedback_generation(\mod_assign\event\assessable_s
         }
 
         // Queue the ad-hoc task.
-        $task = new process_feedback_rubric_adhoc();
+        $task = new process_feedback_adhoc();
         $task->set_custom_data([
             'assignment' => $assignmentid,
             'users' => [$userid],
             'action' => 'generate',
             'triggeredby' => 'auto',
         ]);
-        $task->set_userid(get_admin()->id);
+        // Run as the submitting user so quota and availability checks are correct.
+        $task->set_userid($userid);
         manager::queue_adhoc_task($task, true);
     }
 

classes/aif.php

@@ -20,7 +20,7 @@
 use core_external\external_function_parameters;
 use core_external\external_single_structure;
 use core_external\external_value;
-use assignfeedback_aif\task\process_feedback_rubric_adhoc;
+use assignfeedback_aif\task\process_feedback_adhoc;
 use core\context\module as context_module;
 use core\task\manager;
 
@@ -73,7 +73,7 @@ public static function execute(int $assignmentid, int $userid): array {
         require_capability('mod/assign:grade', $context);
 
         // Queue the ad-hoc task for this single user.
-        $task = new process_feedback_rubric_adhoc();
+        $task = new process_feedback_adhoc();
         $task->set_custom_data([
             'assignment' => $params['assignmentid'],
             'users' => [$params['userid']],

classes/event/observer.php

@@ -40,11 +40,6 @@ public static function handle_purpose_usage(\local_ai_manager\hook\purpose_usage
             'assignfeedback_aif',
             get_string('purposeplacedescription_feedback', 'assignfeedback_aif')
         );
-        $hook->add_purpose_usage_description(
-            'translate',
-            'assignfeedback_aif',
-            get_string('purposeplacedescription_translate', 'assignfeedback_aif')
-        );
         $hook->add_purpose_usage_description(
             'itt',
             'assignfeedback_aif',