Update question_test.php

Clean up the test_build_full_ai_prompt unit test

Author: marcusgreen

tests/question_test.php

@@ -87,21 +87,30 @@ public function test_perform_request(): void {
         $this->assertEquals('8', $response);
     }
     /**
-     * Check the student response gets interprolated into the prompt ready to send
+     * Check the student response gets interpolated into the prompt ready to send
      * off to the LLM
      * @covers \qtype_aitext\question::build_full_ai_prompt
      */
     public function test_build_full_ai_prompt() {
         $this->resetAfterTest(true);
         $question = qtype_aitext_test_helper::make_aitext_question([]);
-        $question->questiontext = 'What is 2 * 4?';
-        $aiprompt = "Is the a correct response to the question 'What is 2 * 4?";
+        $question->questiontext = 'Write an English sentence in the past tense';
+        $aiprompt = "Is the text gramatically correct?";
+        $markscheme  = 'One mark if the response is gramatically correct';
+        $studentresponse = 'Yesterday I went to the park';
         $defaultmark = 1;
-        $markscheme  = 'Give one mark if the response is 8';
-        $studentresponse = 'It is 8';
+
         $result = (string) $question->build_full_ai_prompt($studentresponse, $aiprompt, $defaultmark, $markscheme);
+
+        // Student response is within [ ] delimters. Angle brackets might be better, e.g. <<<< >>>>.
         $pattern = '/\[\[' . $studentresponse . '\]\]/';
         $this->assertEquals(1, preg_match($pattern, $result));
+
+        // HTML tags should be stripped out, though that might change in the future.
+        $this->assertStringNotContainsString('<p>', $result);
+
+        // Marks scheme should be in result ready to send to LLm. Though it is optional.
+        $this->assertStringContainsString($markscheme, $result);
     }
 
     /**