Add delete buttons

Author: marcusgreen

backup/moodle2/restore_qtype_aitext_plugin.class.php

@@ -102,8 +102,7 @@ public static function define_decode_contents() {
      */
     protected function after_execute_question() {
         global $DB;
-
-        $aitextswithoutoptions = $DB->get_records_sql("
+        $qwithoutoptions = $DB->get_records_sql("
                     SELECT q.*
                       FROM {question} q
                       JOIN {backup_ids_temp} bi ON bi.newitemid = q.id
@@ -114,7 +113,7 @@ protected function after_execute_question() {
                        AND bi.itemname = ?
                 ", ['aitext', $this->get_restoreid(), 'question_created']);
 
-        foreach ($aitextswithoutoptions as $q) {
+        foreach ($qwithoutoptions as $q) {
             $defaultoptions = new stdClass();
             $defaultoptions->questionid = $q->id;
             $defaultoptions->aiprompt = '';

db/upgrade.php

@@ -22,7 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-
 /**
  * Upgrade code for the aitext question type.
  *
@@ -100,6 +99,5 @@ function xmldb_qtype_aitext_upgrade($oldversion) {
         upgrade_plugin_savepoint(true, 2024071895, 'qtype', 'aitext');
     }
 
-
     return true;
 }

edit_aitext_form.php

@@ -86,6 +86,7 @@ protected function definition_inner($mform) {
         , ['rows' => 10], $this->editoroptions);
         $mform->addElement('html', '</div>');
 
+        // Add repeated sample answer options along with the field for returned responses.
         $mform->addElement('header', 'prompttester', get_string('prompttester', 'qtype_aitext'));
 
         $answeroptions = ['maxlen' => 50, 'rows' => 6, 'size' => 30];
@@ -95,21 +96,23 @@ protected function definition_inner($mform) {
             $mform->createElement('textarea', 'sampleanswers', get_string('sampleanswer', 'qtype_aitext'), $answeroptions),
             $mform->createElement('textarea', 'sampleanswereval', get_string('sampleanswereval', 'qtype_aitext'), $evaloptions),
             $mform->createelement('button', 'sampleanswerbtn', get_string('sampleanswerevaluate', 'qtype_aitext')),
+            $mform->createElement('submit', 'delete', get_string('deletesample', 'qtype_aitext'), 0),
             $mform->createElement('html', '<hr/>'),
         ];
 
         $repeateloptions = [];
         $mform->setType('sampleanswereval', PARAM_CLEANHTML);
         $mform->setType('optionid', PARAM_INT);
         $samplecount = $this->get_sample_count();
+        $mform->registerNoSubmitButton('delete');
         $this->repeat_elements(
             $repeatarray,
             $samplecount,
             $repeateloptions,
             'option_repeats',
             'option_add_fields',
             1,
-            null,
+            get_string('addsample', 'qtype_aitext'),
             true,
             'delete',
         );
@@ -160,15 +163,23 @@ protected function definition_inner($mform) {
 
         // Load any JS that we need to make things happen, specifically the prompt tester.
         $PAGE->requires->js_call_amd('qtype_aitext/responserun', 'init', [$this->context->id]);
-
     }
+
+    /**
+     * retrieved from function get_sampleanswers in class quesitontype
+     *
+     * @return int count of sample answers
+     */
     protected function get_sample_count() {
         if (isset($this->question->id)) {
-            if(isset($this->question->options->sampleanswers)) {
-                return count($this->question->options->sampleanswers);
+            if (isset($this->question->options->sampleanswers)) {
+                if (count($this->question->options->sampleanswers) > 0) {
+                    return count($this->question->options->sampleanswers);
+                }
             }
         }
-        return 0;
+        // Always have one empty sample answer set of fields.
+        return 1;
     }
 
     /**
@@ -195,7 +206,7 @@ protected function data_preprocessing($question) {
         $question->spellcheck = $question->options->spellcheck;
         // Make the count start from 0 like the repeat array elements.
         $question->sampleanswers = [];
-        foreach($question->options->sampleanswers as $sampleanswer) {
+        foreach ($question->options->sampleanswers as $sampleanswer) {
             $question->sampleanswers[] = $sampleanswer->response;
         }
 

lang/en/qtype_aitext.php

@@ -24,6 +24,7 @@
  */
 
 $string['acceptedfiletypes'] = 'Accepted file types';
+$string['addsample'] = 'Add a sample response';
 $string['aiprompt'] = 'AI Prompt';
 $string['aiprompt_help'] = 'A prompt for the Ai Grader. This is the guideline that AI uses to give feedback on the student response.';
 $string['aipromptmissing'] = 'The ai prompt is missing. Please enter a prompt on the basis of which the feedback is generated.';
@@ -39,6 +40,7 @@
 $string['defaultmarksscheme_setting'] = 'This will be the default marks scheme for new questions. Questions authors should alter this to suit the question.';
 $string['defaultprompt'] = 'AI Prompt';
 $string['defaultprompt_setting'] = 'This will be the default AI prompt for new questions. It tells the AI grader how to analyse the student response. It is the guideline that AI uses to give feedback on the student response. Question authors should alter this to suit the question.';
+$string['deletesample'] = 'Delete sample';
 $string['disclaimer'] = 'Disclaimer';
 $string['disclaimer_setting'] = 'Text appended to each response indicating feedback is from a Large Language Model and not a human';
 $string['err_invalidbackend'] = 'Err invalidbackend;';
@@ -105,17 +107,17 @@
 $string['sampleanswer'] = 'Sample Answer';
 $string['sampleanswer_help'] = 'The sample answer can be used to test how the AI grader will respond to a given response.';
 $string['sampleanswerempty'] = 'Make sure that you have an AI prompt and sample answer before testing.';
-$string['sampleanswerevaluate'] = 'Evaluate Sample Answer';
 $string['sampleanswereval'] = 'Sample Answer Evaluation';
+$string['sampleanswerevaluate'] = 'Evaluate Sample Answer';
 $string['showprompt'] = 'Show prompt';
 $string['spellcheck_editor_desc'] = 'This is the text in which the spelling mistakes have been corrected by AI. You can edit this suggested correction.';
 $string['spellcheck_prompt'] = 'Reproduce the text 1:1. Give no feedback!. But correct all spelling mistakes in the following text: ';
 $string['spellcheck_student_anser_desc'] = 'This is the original student\'s answer';
 $string['spellcheckedit'] = 'Edit spellcheck';
 $string['spellcheckeditor'] = 'Edit the ai based spellcheck';
+$string['testresponses'] = 'Test responses';
 $string['thedefaultmarksscheme'] = 'Deduct a point from the total score for each grammar or spelling mistake.';
 $string['thedefaultprompt'] = 'Explain if there is anything wrong with the grammar and spelling in the text.';
-$string['testresponses'] = 'Test responses';
 $string['toolaimanager'] = 'Tool AI Manager';
 $string['translatepostfix'] = 'Translate postfix';
 $string['translatepostfix_text'] = 'The end of the prompt has "translate the feedback to the language .current_language()" appended';

questiontype.php

@@ -173,6 +173,7 @@ protected function initialise_question_instance(question_definition $question, $
         $question->aiprompt = $questiondata->options->aiprompt;
         $question->markscheme = $questiondata->options->markscheme;
         parent::get_question_options($question);
+        $question->options->sampleanswers = $this->get_sampleanswers($question);
 
         /* Legacy quesitons may not have a model set, so assign the first in the settings */
         if (empty($question->model)) {
@@ -183,11 +184,18 @@ protected function initialise_question_instance(question_definition $question, $
         }
     }
 
+    /**
+     * Get the structure from the database
+     *
+     * @param qtype_aitext $question
+     * @return array
+     */
     public function get_sampleanswers($question) {
         global $DB;
         $sampleanswers = $DB->get_records('qtype_aitext_sampleanswers', ['question' => $question->id]);
         return $sampleanswers;
     }
+
     /**
      * Delete a question from the database
      *

version.php

@@ -25,7 +25,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = 'qtype_aitext';
-$plugin->version   = 2024071895;
+$plugin->version   = 2024111900;
 $plugin->requires  = 2020110900;
 $plugin->release = '0.02';
 $plugin->maturity  = MATURITY_BETA;