Update question_test.php

Clean up the test_build_full_ai_prompt unit test

Author: marcusgreen

tests/question_test.php

@@ -105,37 +105,32 @@ public function test_get_question_summary(): void {
             $aitext->questiontext = 'Hello <img src="http://example.com/globe.png" alt="world" />';
             $this->assertEquals('Hello [world]', $aitext->get_question_summary());
     }
-
+ 
     /**
-     * Check on some permutations of how the prompt that is sent to the
-     * LLM is constructed
-     * @covers ::build_full_ai_prompt
+     * Check the student response gets interpolated into the prompt ready to send
+     * off to the LLM
+     * @covers \qtype_aitext\question::build_full_ai_prompt
      */
-    public function test_build_full_ai_prompt(): void {
-        $this->resetAfterTest();
-        if (!$this->islive) {
-                $this->markTestSkipped('No live connection to the AI system');
-        }
-
+    public function test_build_full_ai_prompt() {
+        $this->resetAfterTest(true);
         $question = qtype_aitext_test_helper::make_aitext_question([]);
-        set_config('prompt', 'in [responsetext] ', 'qtype_aitext');
-        set_config('defaultprompt', 'check this', 'qtype_aitext');
-        set_config('markscheme', 'one mark', 'qtype_aitext');
-        set_config('jsonprompt', 'testprompt', 'qtype_aitext');
-
-        $response = '<p> Thank you </p>';
-        $aiprompt = '';
-        $defaultmark = '';
-        $markscheme = '';
-        $result = $question->build_full_ai_prompt($response, $aiprompt, $defaultmark, $markscheme);
-
-        $this->assertStringContainsString('[[ Thank you ]]', $result);
-        // HTML tags should be stripped out.
+        $question->questiontext = 'Write an English sentence in the past tense';
+        $aiprompt = "Is the text gramatically correct?";
+        $markscheme  = 'One mark if the response is gramatically correct';
+        $studentresponse = 'Yesterday I went to the park';
+        $defaultmark = 1;
+
+        $result = (string) $question->build_full_ai_prompt($studentresponse, $aiprompt, $defaultmark, $markscheme);
+
+        // Student response is within [ ] delimters. Angle brackets might be better, e.g. <<<< >>>>.
+        $pattern = '/\[\[' . $studentresponse . '\]\]/';
+        $this->assertEquals(1, preg_match($pattern, $result));
+
+        // HTML tags should be stripped out, though that might change in the future.
         $this->assertStringNotContainsString('<p>', $result);
 
-        $markscheme = "2 points";
-        $result = $question->build_full_ai_prompt($response, $aiprompt, $defaultmark, $markscheme);
-        $this->assertStringContainsString('2 points', $result);
+        // Marks scheme should be in result ready to send to LLm. Though it is optional.
+        $this->assertStringContainsString($markscheme, $result);
     }
 
     /**