Skip to content

Commit adc469a

Browse files
author
Mariana Azevedo
committed
Updates AST Parser and using computeIfAbsence on maps.
1 parent ee1e989 commit adc469a

File tree

5 files changed

+12
-20
lines changed

5 files changed

+12
-20
lines changed

src/com/o3smeasures/plugin/chart/BarChart.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -144,15 +144,7 @@ private void createFactors(ItemMeasured itemsMeasured) throws FactorNotFoundExce
144144

145145
String factorName = O3SMeasuresConfigurationEnum.searchByValue(item.getName()).getFactor();
146146
if (!factorName.equals("None") && !factorName.equals("High Cohesion of Methods")){
147-
Factor factor = factorsMap.get(factorName);
148-
149-
if (factor == null){
150-
factor = new Factor();
151-
factor.setName(factorName);
152-
factor.setDescription(factorName);
153-
factor.setNumberOfIndicators(0);
154-
factorsMap.put(factorName, factor);
155-
}
147+
Factor factor = factorsMap.computeIfAbsent(factorName, f -> new Factor(factorName, factorName, 0));
156148
factor.getIndicators().add(new Indicator(item, 0.0));
157149
factor.setNumberOfIndicators(factor.getNumberOfIndicators()+1);
158150
}

src/com/o3smeasures/plugin/chart/BoxAndWhiskerChart.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,7 @@ private void createFactors(ItemMeasured itemsMeasured) throws FactorNotFoundExce
111111

112112
String factorName = O3SMeasuresConfigurationEnum.searchByValue(item.getName()).getFactor();
113113
if (!factorName.equals("None") && !factorName.equals("High Cohesion of Methods")){
114-
Factor factor = factorsMap.get(factorName);
115-
116-
if (factor == null){
117-
factor = new Factor();
118-
factor.setName(factorName);
119-
factor.setDescription(factorName);
120-
factorsMap.put(factorName, factor);
121-
}
114+
Factor factor = factorsMap.computeIfAbsent(factorName, f -> new Factor(factorName, factorName, 0));
122115
factor.getIndicators().add(new Indicator(item, 0.0));
123116
}
124117
}

src/com/o3smeasures/statistic/Factor.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,14 @@ public class Factor {
1717
private int numberOfIndicators;
1818

1919
public Factor(){
20-
indicators = new ArrayList<>();
20+
this.indicators = new ArrayList<>();
21+
}
22+
23+
public Factor(String name, String description, int numberOfIndicators) {
24+
this.name = name;
25+
this.description = description;
26+
this.numberOfIndicators = numberOfIndicators;
27+
this.indicators = new ArrayList<>();
2128
}
2229

2330
public String getName() {

src/com/o3smeasures/structures/Measure.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public enum Granularity {
3434

3535
public Measure(){
3636
applicableGranularities = new ArrayList<>(4);
37-
parser = ASTParser.newParser(AST.JLS8);
37+
parser = ASTParser.newParser(AST.JLS9);
3838
parser.setKind(ASTParser.K_COMPILATION_UNIT);
3939
parser.setResolveBindings(true);
4040
}

src/com/o3smeasures/util/JavaParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public static CompilationUnit parseAST(FileInputStream fileInputStream){
6969
ASTSession.getInstance().reset();
7070

7171
if (cacheParser) {
72-
astParser = ASTParser.newParser(AST.JLS8);
72+
astParser = ASTParser.newParser(AST.JLS9);
7373
astParser.setKind(ASTParser.K_COMPILATION_UNIT);
7474
astParser.setResolveBindings(true);
7575
char[] source = getFileContent(fileInputStream);

0 commit comments

Comments
 (0)