Skip to content

Commit 3fb4dff

Browse files
committed
[infra-dashboard] Fix stale comment about Connect RPC JSON support
All Connect RPC methods support JSON natively via POST + Content-Type application/json — the old comment claiming /health was "the only easily-callable JSON endpoint" was wrong since we added the SQL-backed panels. Addressed PR review feedback from rjpower.
1 parent dd6a32d commit 3fb4dff

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

infra/status-page/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,9 @@ break** — we'll need to plumb a service-account bearer token.
228228
so history lives authoritatively next to the workers table.
229229
- **Iris panel reachability row** is still `/health`-only. Worker counts
230230
and job-state breakdowns are surfaced in the Workers and Jobs
231-
subsections; tasks / autoscaler / detailed state are still behind the
232-
full Connect RPC surface and would need generated TypeScript stubs
233-
(or more `ExecuteRawQuery` SQL).
231+
subsections via `ExecuteRawQuery` SQL. Tasks, autoscaler, and detailed
232+
state are available via other Connect RPC methods (all support JSON
233+
natively) but would need additional SQL or direct RPC calls wired up.
234234
- **Single cluster only** (`marin`). Extending to `marin-dev` means
235235
adding a second Cloud Run service or making the existing one
236236
multi-cluster.

infra/status-page/server/sources/iris.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
// Iris controller reachability.
1+
// Iris controller reachability via the /health endpoint.
22
//
3-
// In v1, the controller's only easily-callable JSON endpoint is /health
4-
// (see lib/iris/src/iris/cluster/controller/dashboard.py:396). Everything
5-
// else is HTML dashboard or Connect RPC. This source reports reachability
6-
// + round-trip latency and leaves room in the response shape for richer
7-
// data later (which is increasingly supplied by the workers and jobs
8-
// sources reading the controller's SQLite directly via ExecuteRawQuery).
3+
// All Connect RPC methods on the controller support JSON natively
4+
// (POST + Content-Type: application/json), which is how the workers
5+
// and jobs sources call ExecuteRawQuery. This source sticks with the
6+
// simpler /health GET because it only needs a binary reachable/latency
7+
// signal, not structured data from the controller's SQLite.
98

109
import { getControllerUrl } from "./discovery.js";
1110

0 commit comments

Comments
 (0)