Skip to content

Commit 42c95f4

Browse files
rjpowerclaude
andcommitted
fix: address PR review feedback on coreweave CI workflow
- Restrict pull_request trigger to types: [opened, synchronize] to avoid unnecessary runs on label/assignment changes - Add pull-requests: read permission for issue_comment trigger - Detect port-forward process death during health check loop - Use pkill fallback in cleanup step for robustness when PF_PID is empty Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ce841e8 commit 42c95f4

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/iris-coreweave-ci.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ name: Iris - CoreWeave CI
22

33
on:
44
pull_request:
5+
types: [opened, synchronize]
56
paths:
67
- "lib/iris/**"
78
issue_comment:
@@ -11,7 +12,8 @@ on:
1112
permissions:
1213
contents: read
1314
packages: write
14-
statuses: write
15+
pull-requests: read # needed for issue_comment to access PR metadata
16+
statuses: write # post commit status from issue_comment trigger
1517

1618
# Single concurrency group — only one CW CI run at a time across all PRs.
1719
# The warm cluster is shared; concurrent runs would conflict.
@@ -121,6 +123,10 @@ jobs:
121123
# this just waits for the port-forward to be usable.
122124
HEALTHY=false
123125
for i in $(seq 1 60); do
126+
if ! kill -0 "$PF_PID" 2>/dev/null; then
127+
echo "port-forward process died unexpectedly"
128+
exit 1
129+
fi
124130
if curl -sf "$IRIS_CONTROLLER_URL/healthz" > /dev/null 2>&1; then
125131
HEALTHY=true
126132
break
@@ -140,7 +146,9 @@ jobs:
140146
141147
- name: Stop port-forward
142148
if: always()
143-
run: kill $PF_PID 2>/dev/null || true
149+
run: |
150+
[ -n "$PF_PID" ] && kill "$PF_PID" 2>/dev/null || true
151+
pkill -f "kubectl port-forward.*$IRIS_NAMESPACE" 2>/dev/null || true
144152
145153
- name: Capture failure diagnostics
146154
if: failure()

0 commit comments

Comments
 (0)