Skip to content

Commit 9961943

Browse files
committed
fix: add is_remote field, fix workflow URL check, remove dead code
- Add `is_remote: bool = False` to IrisIntegrationCluster dataclass - Use local `$URL` variable instead of `$IRIS_CONTROLLER_URL` in same-step check - Remove unused `validate_job_context` from jobs.py
1 parent 46f12a0 commit 9961943

3 files changed

Lines changed: 2 additions & 15 deletions

File tree

.github/workflows/iris-integration.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
sleep 1
6060
done
6161
62-
if [ -z "${IRIS_CONTROLLER_URL:-}" ]; then
62+
if [ -z "${URL:-}" ]; then
6363
echo "Cluster failed to start within timeout"
6464
cat /tmp/iris-cluster.log
6565
exit 1

tests/integration/iris/cluster.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class IrisIntegrationCluster:
3333
url: str
3434
client: IrisClient
3535
controller_client: ControllerServiceClientSync
36+
is_remote: bool = False
3637
job_timeout: float = 60.0
3738

3839
def submit(

tests/integration/iris/jobs.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -97,17 +97,3 @@ def validate_ports():
9797
raise ValueError(f"Ports not set: {info.ports}")
9898
assert info.ports["http"] > 0
9999
assert info.ports["grpc"] > 0
100-
101-
102-
def validate_job_context():
103-
"""Validate job context via get_job_info() in a coscheduled job."""
104-
import logging
105-
106-
from iris.cluster.client import get_job_info
107-
108-
logger = logging.getLogger("iris.test.context")
109-
info = get_job_info()
110-
if info is None:
111-
raise RuntimeError("Not running in an Iris job context")
112-
logger.info(f"Task {info.task_index} of {info.num_tasks} on worker {info.worker_id}")
113-
return f"Task {info.task_index} done"

0 commit comments

Comments
 (0)