fix: detect missing proto outputs in iris hatch build hook

The build hook only compared timestamps to decide if regeneration was
needed, so adding a new .proto file (query.proto in #3649) without
regenerating left query_pb2.py missing — breaking all local iris CLI
usage.

Add _has_missing_outputs() to check that every .proto has its _pb2.py
counterpart, and use it in both the rebuild decision and the npx/script
fallback paths so they raise instead of silently continuing with
incomplete outputs.

Also add the missing query_pb2 import to rpc/__init__.py (required by
the descriptor pool load order since cluster.proto imports query.proto).

Fixes #3709

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: yonromai

lib/iris/hatch_build.py

@@ -57,13 +57,29 @@ def _outputs_exist(root: Path, output_globs: list[str]) -> bool:
     return _oldest_mtime(root, output_globs) > 0.0
 
 
+def _has_missing_outputs(root: Path, source_globs: list[str]) -> bool:
+    """Return True if any .proto source is missing its corresponding _pb2.py."""
+    for pattern in source_globs:
+        for proto_path in root.glob(pattern):
+            pb2_path = proto_path.with_name(proto_path.stem + "_pb2.py")
+            if not pb2_path.exists():
+                return True
+    return False
+
+
 def _needs_rebuild(root: Path, source_globs: list[str], output_globs: list[str]) -> bool:
-    """Return True if any source file is strictly newer than the oldest output file.
+    """Return True if outputs are incomplete or stale.
+
+    Checks two conditions:
+    1. Any .proto source is missing its _pb2.py output (new proto added).
+    2. Any source file is strictly newer than the oldest output file.
 
     Uses a 60-second tolerance because zip archives (used by task bundles)
     can extract files with slightly different timestamps, causing spurious
     rebuilds.
     """
+    if _has_missing_outputs(root, source_globs):
+        return True
     source_newest = _newest_mtime(root, source_globs)
     output_oldest = _oldest_mtime(root, output_globs)
     return source_newest > output_oldest + 60.0
@@ -78,14 +94,15 @@ def initialize(self, version: str, build_data: dict) -> None:
 
     def _maybe_generate_protos(self, root: Path) -> None:
         outputs_present = _outputs_exist(root, _PROTO_OUTPUT_GLOBS)
+        outputs_complete = outputs_present and not _has_missing_outputs(root, _PROTO_SOURCE_GLOBS)
 
-        if outputs_present and not _needs_rebuild(root, _PROTO_SOURCE_GLOBS, _PROTO_OUTPUT_GLOBS):
+        if outputs_complete and not _needs_rebuild(root, _PROTO_SOURCE_GLOBS, _PROTO_OUTPUT_GLOBS):
             logger.info("Protobuf outputs are up-to-date, skipping generation")
             return
 
         generate_script = root / "scripts" / "generate_protos.py"
         if not generate_script.exists():
-            if not outputs_present:
+            if not outputs_complete:
                 raise RuntimeError(
                     "Protobuf outputs are missing and scripts/generate_protos.py not found. "
                     "Cannot build iris without generated protobuf files."
@@ -94,7 +111,7 @@ def _maybe_generate_protos(self, root: Path) -> None:
             return
 
         if shutil.which("npx") is None:
-            if not outputs_present:
+            if not outputs_complete:
                 raise RuntimeError(
                     "Protobuf outputs are missing and npx is not installed. "
                     "Install Node.js (which provides npx) to generate protobuf files: "

lib/iris/src/iris/rpc/__init__.py

@@ -2,8 +2,9 @@
 # SPDX-License-Identifier: Apache-2.0
 
 # Import order matters for proto descriptor pool: each module must be loaded
-# after its dependencies. Chain: time → config → vm → cluster.
+# after its dependencies. Chain: time → config → vm → query → cluster.
 from iris.rpc import time_pb2 as time_pb2
 from iris.rpc import config_pb2 as config_pb2
 from iris.rpc import vm_pb2 as vm_pb2
+from iris.rpc import query_pb2 as query_pb2
 from iris.rpc import cluster_pb2 as cluster_pb2