Skip to content

Commit beabe26

Browse files
rjpowerclaude
andcommitted
pyrefly: cluster B cleanup (arg / overload noise)
Re-enable the remaining cluster-B categories in `[tool.pyrefly.errors]` and fix the real bugs called out in the cluster-B memo. Residual diagnostics (including the ~80 haliax `Axis` widening items, deferred to a follow-on project) land in the baseline. Categories re-enabled: - bad-argument-count - missing-argument - unexpected-keyword - no-matching-overload - bad-argument-type Real-bug fixes: - iris controller: widen `_inject_reservation_taints` and `_building_counts` to `Sequence[WorkerSnapshot]` so covariant `list[WorkerRow]` callers satisfy the protocol. Fixes the WorkerSnapshot/WorkerRow swap diagnostics at controller.py:1892, 1896, 2074, 2076. - zephyr plan: `Map.fn` was typed `Callable[[Iterator], Iterator]` but is called with `(stream, shard_info)` when `needs_shard_context=True`. Widen to `Callable[..., Iterator]` to match the documented contract. - delete `lib/marin/src/marin/rl/scripts/replay_completions.py` — no callers in the repo, stale against the current `InferenceServer.create` and `InferenceServerConfig` signatures. Deferred: - haliax `Axis` widening audit (~80 diagnostics in baseline). Per user decision, will be scoped as a separate `.agents/projects/` doc rather than in this cluster PR. - fix-soon Optional-narrowing sweep (~196 sites) across marin/iris/ zephyr. Baselined with visibility for per-package follow-up PRs. Baseline delta: 9,327 → 19,983 lines, 776 → 1,665 diagnostics. Only `missing-import = false` remains in `[tool.pyrefly.errors]`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 9e95f88 commit beabe26

File tree

5 files changed

+16084
-5712
lines changed

5 files changed

+16084
-5712
lines changed

0 commit comments

Comments
 (0)