Open
Conversation
Contributor
|
This pull request has been inactive for 23 days and is marked as stale. |
Collaborator
|
@claude rebase this PR to main, we shouldn't have any more GetTaskLogs clients at this point. |
Contributor
Author
|
Claude finished @rjpower's task in 8m 55s —— View job Rebased to main ✅The branch is now rebased onto What was done
Final diff: 5 files, +63 / -269 (most of the deletes are in regenerated proto bindings). How I tested
Pushed to |
All callers have been migrated to use FetchLogs with regex source patterns. This removes: - GetTaskLogsRequest, TaskLogBatch, GetTaskLogsResponse proto messages - GetTaskLogs RPC from ControllerService - get_task_logs forwarding method from ControllerServiceImpl - Unused build_log_source / re imports and DEFAULT_MAX_TOTAL_LINES constant - Regenerated controller_pb2.py / controller_pb2.pyi / controller_connect.py Closes #4201 Co-authored-by: Russell Power <rjpower@users.noreply.github.com>
1406332 to
d2462e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated GetTaskLogs RPC and all associated code. All callers were previously migrated to use FetchLogs with regex source patterns directly.
Removed:
Not removed:
Test plan:
Closes #4201
Generated with Claude Code