Skip to content

Remove deprecated GetTaskLogs RPC#4231

Open
claude[bot] wants to merge 1 commit intomainfrom
claude/issue-4201-20260328-1855
Open

Remove deprecated GetTaskLogs RPC#4231
claude[bot] wants to merge 1 commit intomainfrom
claude/issue-4201-20260328-1855

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented Mar 28, 2026

Removes the deprecated GetTaskLogs RPC and all associated code. All callers were previously migrated to use FetchLogs with regex source patterns directly.

Removed:

  • Proto (cluster.proto): GetTaskLogsRequest, TaskLogBatch, GetTaskLogsResponse messages and GetTaskLogs RPC
  • Service (service.py): get_task_logs forwarding method, unused build_log_source import, DEFAULT_MAX_TOTAL_LINES constant
  • Docs (vue-refactor.md): Updated stale GetTaskLogs example to use FetchLogs

Not removed:

  • Test helper methods named get_task_logs in _docker_cluster.py and conftest.py - these already use FetchLogs internally

Test plan:

  • pre-commit passes
  • test_dashboard.py - 32 passed
  • Full iris unit test suite (excluding e2e/chaos) - 1669 passed, 1 skipped

Closes #4201

Generated with Claude Code

@claude claude Bot added the agent-generated Created by automation/agent label Mar 28, 2026
@claude claude Bot requested a review from rjpower March 28, 2026 19:06
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been inactive for 23 days and is marked as stale.
If there is no further activity within 7 days, it will be automatically closed.
If you believe this PR should remain open, please add a comment or update the PR.

@github-actions github-actions Bot added the stale label Apr 21, 2026
@rjpower
Copy link
Copy Markdown
Collaborator

rjpower commented Apr 22, 2026

@claude rebase this PR to main, we shouldn't have any more GetTaskLogs clients at this point.

@claude
Copy link
Copy Markdown
Contributor Author

claude Bot commented Apr 22, 2026

Claude finished @rjpower's task in 8m 55s —— View job


Rebased to main ✅

The branch is now rebased onto 7dd69d706 (current origin/main) as a single commit d2462e602.

What was done

  • Branch was 20 commits behind origin/main. A literal rebase produced 30+ unrelated add/add conflicts (file moves under tests/, tests/snapshots/, uv.lock), so I reset to origin/main and re-applied the GetTaskLogs removal cleanly.
  • The proto file was renamed cluster.protocontroller.proto upstream — applied the changes there.
  • Removed GetTaskLogsRequest / TaskLogBatch / GetTaskLogsResponse messages and the GetTaskLogs RPC.
  • Removed get_task_logs(), the now-unused re and build_log_source imports, and the DEFAULT_MAX_TOTAL_LINES constant from service.py.
  • Regenerated controller_pb2.py, controller_pb2.pyi, and controller_connect.py via lib/iris/scripts/generate_protos.py.
  • lib/iris/docs/vue-refactor.md no longer exists in main, so no doc update is needed.
  • Verified zero GetTaskLogs / get_task_logs references remain in lib/iris/src/iris/. The test helpers under tests/e2e/conftest.py and tests/e2e/_docker_cluster.py keep the local helper name get_task_logs but already implement it via FetchLogs — left as-is, matching the original PR's stated scope.

Final diff: 5 files, +63 / -269 (most of the deletes are in regenerated proto bindings).

How I tested

  • ./infra/pre-commit.py --all-files --fixOK (all hooks green, including pyrefly).
  • uv run pytest tests/cluster/controller/test_service.py tests/cluster/test_attempt_logs.py53 passed.
  • uv run pytest tests/cluster tests/rpc tests/log_server tests/cli tests/actor tests/client --ignore=tests/cluster/test_chaos.py1799 passed, 1 skipped in 90s.

Pushed to claude/issue-4201-20260328-1855. The PR (now 1 commit ahead of main) is ready for re-review.
· Branch

All callers have been migrated to use FetchLogs with regex source patterns.
This removes:
- GetTaskLogsRequest, TaskLogBatch, GetTaskLogsResponse proto messages
- GetTaskLogs RPC from ControllerService
- get_task_logs forwarding method from ControllerServiceImpl
- Unused build_log_source / re imports and DEFAULT_MAX_TOTAL_LINES constant
- Regenerated controller_pb2.py / controller_pb2.pyi / controller_connect.py

Closes #4201

Co-authored-by: Russell Power <rjpower@users.noreply.github.com>
@claude claude Bot force-pushed the claude/issue-4201-20260328-1855 branch from 1406332 to d2462e6 Compare April 22, 2026 22:22
@github-actions github-actions Bot removed the stale label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated Created by automation/agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated GetTaskLogs RPC

1 participant