[fray] Remove 24h default timeout on job wait#4380
Merged
ravwojdyla merged 3 commits intomainfrom Apr 6, 2026
Merged
Conversation
The fray Iris backend defaulted to 86400s (24h) when no timeout was specified, causing long-running zephyr pipelines to be killed and retried unnecessarily. Use infinity instead so jobs wait until completion or explicit cancellation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
no claude, bad @claude. I wanted to have |
Contributor
|
Claude finished @ravwojdyla's task in 17m 21s —— View job Scoped infinite timeout to zephyr coordinator only
Changes made
Testing
|
Revert the global IrisJobHandle.wait() default from float("inf") back to
86400.0 and instead pass timeout=float("inf") only at the zephyr
coordinator call site. Also guard local and ray backends against
float("inf") since concurrent.futures and ray.get cannot handle it.
Co-authored-by: Rafal Wojdyla <ravwojdyla@users.noreply.github.com>
Collaborator
|
Let's use None as the indicator? As we've seen float("inf") isn't handled well by either Ray or local backends? (or some other sentinel like "5 years from now" is also fine) |
Contributor
|
@claude address above |
Contributor
|
Claude finished @ravwojdyla's task in 4m 46s —— View job Addressed rjpower's feedback: use
|
Per review feedback, None is a cleaner sentinel than float("inf") since
both ray.get() and Future.result() already treat None as "wait forever".
The Iris client still needs a numeric timeout, so None maps to ~5 years.
Co-authored-by: Rafal Wojdyla <ravwojdyla@users.noreply.github.com>
rjpower
approved these changes
Apr 3, 2026
Helw150
pushed a commit
that referenced
this pull request
Apr 8, 2026
## Summary
- Replace the hard-coded 24h (`86400.0`) default timeout in
`IrisJobHandle.wait()` with `float("inf")`, so callers that pass
`timeout=None` wait indefinitely instead of silently timing out after a
day.
## Test plan
- [x] Verified the change applies cleanly
- [ ] Run fray jobs that exceed 24h and confirm they no longer time out
unexpectedly
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Rafal Wojdyla <ravwojdyla@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Rafal Wojdyla <ravwojdyla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
86400.0) default timeout inIrisJobHandle.wait()withfloat("inf"), so callers that passtimeout=Nonewait indefinitely instead of silently timing out after a day.Test plan
🤖 Generated with Claude Code