Skip to content

[iris] Remove broken test_worker_restart_preserves_task smoke test#4855

Merged
rjpower merged 1 commit intomainfrom
claude/remove-broken-worker-restart-test
Apr 17, 2026
Merged

[iris] Remove broken test_worker_restart_preserves_task smoke test#4855
rjpower merged 1 commit intomainfrom
claude/remove-broken-worker-restart-test

Conversation

@rjpower
Copy link
Copy Markdown
Collaborator

@rjpower rjpower commented Apr 17, 2026

The test has been failing for a while with "Slice ... not found in group" errors from the restart_worker RPC. Removing it for now until the underlying slice bookkeeping is fixed.

The test has been failing for a while with "Slice ... not found in group"
errors from the restart_worker RPC. Removing it for now until the underlying
slice bookkeeping is fixed.
@rjpower rjpower added the agent-generated Created by automation/agent label Apr 17, 2026
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 17, 2026

Claude finished @rjpower's task in 41s —— View job


Code review

No issues found. Checked for bugs and CLAUDE.md/AGENTS.md compliance.

Summary

  • Pure deletion of 64 lines: removes test_worker_restart_preserves_task from lib/iris/tests/e2e/test_smoke.py.
  • No other references to the test exist in the repo (rg test_worker_restart_preserves_task returns no matches).
  • Surrounding structure (section header for Checkpoint / restore, adjacent test_exec_in_container) is intact.
  • PR body documents the reason (persistent "Slice ... not found in group" failures from restart_worker RPC) and signals this is a temporary removal pending a fix to slice bookkeeping — consistent with AGENTS.md guidance to delete dead/broken code rather than paper over it.

Recommendation: consider opening (or linking) a tracking issue for the underlying slice bookkeeping bug so restart coverage gets restored once fixed. Not blocking.
· Branch

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6157c54371

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread lib/iris/tests/e2e/test_smoke.py
@rjpower rjpower merged commit 8ef19cc into main Apr 17, 2026
46 checks passed
@rjpower rjpower deleted the claude/remove-broken-worker-restart-test branch April 17, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated Created by automation/agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant