Skip to content

[iris] Include per-job autoscaler hint in GetJobStatus#4859

Open
rjpower wants to merge 1 commit intomainfrom
claude/interesting-banach-7ee76e
Open

[iris] Include per-job autoscaler hint in GetJobStatus#4859
rjpower wants to merge 1 commit intomainfrom
claude/interesting-banach-7ee76e

Conversation

@rjpower
Copy link
Copy Markdown
Collaborator

@rjpower rjpower commented Apr 17, 2026

The hint was dropped from GetJobStatus because rebuilding the full routing table per call was 35% of wall time. #4848 now caches the per-job hint dict per evaluate() cycle, so the lookup is a single dict get — attach this job's hint without serializing the routing decision.

The hint was dropped from GetJobStatus because rebuilding the full
routing table per call was 35% of wall time. #4848 now caches the
per-job hint dict per evaluate() cycle, so the lookup is a single
dict get — attach this job's hint without serializing the routing
decision.
@rjpower rjpower added the agent-generated Created by automation/agent label Apr 17, 2026
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 17, 2026

Claude finished @rjpower's task in 2m 0s —— View job


Code review

No issues found. Checked for bugs and AGENTS.md compliance.

  • Check PR eligibility for review
  • Gather relevant AGENTS.md files (root + lib/iris/AGENTS.md)
  • Summarize PR changes
  • Parallel review for bugs + AGENTS.md compliance
  • Validate findings
  • Post review

The new GetJobStatus hint-attach path at service.py#L1232-L1239 mirrors the existing ListJobs formatter at service.py#L1365-L1372, so both endpoints emit the same Scheduler: … / Autoscaler: (scaling up) … format. _get_autoscaler_pending_hints() safely returns {} when no autoscaler is configured, and the per-cycle cache the comment cites (#4848) is confirmed at autoscaler/runtime.py#L583-L591. Test updates correctly flip the prior negative assertions to positive substring checks and add a (scaling up) prefix check.
· Branch

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 17, 2026

Code review

No issues found. Checked for bugs and AGENTS.md compliance.

The GetJobStatus hint-attach path at lib/iris/src/iris/cluster/controller/service.py#L1232-L1239 mirrors the existing ListJobs formatter at service.py#L1365-L1372, so both endpoints emit the same Scheduler: … / Autoscaler: (scaling up) … format. _get_autoscaler_pending_hints() safely returns {} when no autoscaler is configured, and the per-cycle cache referenced in the comment (#4848) is confirmed at autoscaler/runtime.py#L583-L591. Test updates correctly flip the previous negative assertions to positives and add a (scaling up) prefix check.

View job run

@rjpower rjpower requested a review from yonromai April 17, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated Created by automation/agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant