Fem: Clean up constraint

Author: marioalexis84

src/Mod/Fem/Gui/TaskFemConstraint.cpp

@@ -65,45 +65,10 @@ TaskFemConstraint::TaskFemConstraint(ViewProviderFemConstraint* ConstraintView,
     , cancelButton(nullptr)
 {
     selectionMode = selref;
-
-    // Setup the dialog inside the Shaft Wizard dialog
-    if ((ConstraintView->wizardWidget) && (ConstraintView->wizardSubLayout)) {
-        // Hide the shaft wizard table widget to make more space
-        ConstraintView->wizardSubLayout->itemAt(0)->widget()->hide();
-        QGridLayout* buttons = ConstraintView->wizardSubLayout->findChild<QGridLayout*>();
-        for (int b = 0; b < buttons->count(); b++) {
-            buttons->itemAt(b)->widget()->hide();
-        }
-
-        // Show this dialog for the FEM constraint
-        ConstraintView->wizardWidget->addWidget(this);
-
-        // Add buttons to finish editing the constraint without closing the shaft wizard dialog
-        okButton = new QPushButton(QObject::tr("Ok"));
-        cancelButton = new QPushButton(QObject::tr("Cancel"));
-        buttonBox = new QDialogButtonBox();
-        buttonBox->addButton(okButton, QDialogButtonBox::AcceptRole);
-        buttonBox->addButton(cancelButton, QDialogButtonBox::RejectRole);
-        QObject::connect(okButton, &QPushButton::clicked, this, &TaskFemConstraint::onButtonWizOk);
-        QObject::connect(cancelButton,
-                         &QPushButton::clicked,
-                         this,
-                         &TaskFemConstraint::onButtonWizCancel);
-        ConstraintView->wizardWidget->addWidget(buttonBox);
-    }
 }
 
 void TaskFemConstraint::keyPressEvent(QKeyEvent* ke)
 {
-    if ((ConstraintView->wizardWidget) && (ConstraintView->wizardSubLayout)) {
-        // Prevent <Enter> from closing this dialog AND the shaft wizard dialog
-        // TODO: This should trigger an update in the shaft wizard but its difficult to access a
-        // python dialog from here...
-        if (ke->key() == Qt::Key_Return) {
-            return;
-        }
-    }
-
     TaskBox::keyPressEvent(ke);
 }
 
@@ -172,37 +137,6 @@ void TaskFemConstraint::onButtonReference(const bool pressed)
     Gui::Selection().clearSelection();
 }
 
-void TaskFemConstraint::onButtonWizOk()
-{
-    // Remove dialog elements
-    buttonBox->removeButton(okButton);
-    delete okButton;
-    buttonBox->removeButton(cancelButton);
-    delete cancelButton;
-    ConstraintView->wizardWidget->removeWidget(buttonBox);
-    delete buttonBox;
-    ConstraintView->wizardWidget->removeWidget(this);
-
-    // Show the wizard shaft dialog again
-    ConstraintView->wizardSubLayout->itemAt(0)->widget()->show();
-    QGridLayout* buttons = ConstraintView->wizardSubLayout->findChild<QGridLayout*>();
-    for (int b = 0; b < buttons->count(); b++) {
-        buttons->itemAt(b)->widget()->show();
-    }
-
-    Gui::Application::Instance->activeDocument()
-        ->resetEdit();  // Reaches ViewProviderFemConstraint::unsetEdit() eventually
-}
-
-void TaskFemConstraint::onButtonWizCancel()
-{
-    Fem::Constraint* pcConstraint = static_cast<Fem::Constraint*>(ConstraintView->getObject());
-    if (pcConstraint) {
-        pcConstraint->getDocument()->removeObject(pcConstraint->getNameInDocument());
-    }
-    onButtonWizOk();
-}
-
 const QString TaskFemConstraint::makeRefText(const std::string& objName,
                                              const std::string& subName) const
 {

src/Mod/Fem/Gui/TaskFemConstraint.h

@@ -61,9 +61,6 @@ protected Q_SLOTS:
     void onReferenceDeleted(const int row);
     void onButtonReference(const bool pressed = true);
     void setSelection(QListWidgetItem* item);
-    // Shaft Wizard integration
-    void onButtonWizOk();
-    void onButtonWizCancel();
 
 protected:
     void changeEvent(QEvent* e) override

src/Mod/Fem/Gui/ViewProviderFemConstraint.cpp

@@ -32,19 +32,17 @@
 #include <Inventor/nodes/SoShapeHints.h>
 #include <Inventor/nodes/SoTransform.h>
 #include <QAction>
-#include <QDockWidget>
 #include <QMenu>
-#include <QStackedWidget>
 #endif
 
 #include "App/Application.h"
 #include "Gui/Command.h"
 #include "Gui/Control.h"
 #include "Gui/Document.h"
 #include "Gui/MainWindow.h"
+#include "Gui/Selection.h"
 #include "Mod/Fem/App/FemConstraint.h"
 
-#include "TaskFemConstraint.h"
 #include "ViewProviderFemConstraint.h"
 #include "ViewProviderFemConstraintPy.h"
 
@@ -60,8 +58,6 @@ ViewProviderFemConstraint::ViewProviderFemConstraint()
     , pExtraSymbol(nullptr)
     , pExtraTrans(nullptr)
     , ivFile(nullptr)
-    , wizardWidget(nullptr)
-    , wizardSubLayout(nullptr)
     , constraintDialog(nullptr)
 {
     pShapeSep = new SoSeparator();
@@ -151,7 +147,7 @@ void ViewProviderFemConstraint::setDisplayMode(const char* ModeName)
     if (strcmp(ModeName, "Base") == 0) {
         setDisplayMaskMode("Base");
     }
-    ViewProviderDocumentObject::setDisplayMode(ModeName);
+    ViewProviderGeometryObject::setDisplayMode(ModeName);
 }
 
 std::vector<App::DocumentObject*> ViewProviderFemConstraint::claimChildren() const
@@ -164,7 +160,7 @@ void ViewProviderFemConstraint::setupContextMenu(QMenu* menu, QObject* receiver,
     QAction* act;
     act = menu->addAction(QObject::tr("Edit analysis feature"), receiver, member);
     act->setData(QVariant((int)ViewProvider::Default));
-    ViewProviderDocumentObject::setupContextMenu(menu,
+    ViewProviderGeometryObject::setupContextMenu(menu,
                                                  receiver,
                                                  member);  // clazy:exclude=skipped-base-method
 }
@@ -283,26 +279,15 @@ void ViewProviderFemConstraint::unsetEdit(int ModNum)
 {
     // clear the selection (convenience)
     Gui::Selection().clearSelection();
-
-    if (wizardWidget && wizardSubLayout && constraintDialog) {
-        wizardWidget = nullptr;
-        wizardSubLayout = nullptr;
-        delete constraintDialog;
-        constraintDialog = nullptr;
-
-        // Notify the Shaft Wizard that we have finished editing
-        // See WizardShaft.py on why we do it this way
-        Gui::Command::runCommand(Gui::Command::Doc,
-                                 "Gui.runCommand('PartDesign_WizardShaftCallBack')");
+    printf("unset 0\t%d\n", ModNum);
+    if (ModNum == ViewProvider::Default) {
+        // when pressing ESC make sure to close the dialog
+        printf("unset 1\n");
+        Gui::Control().closeDialog();
     }
     else {
-        if (ModNum == ViewProvider::Default) {
-            // when pressing ESC make sure to close the dialog
-            Gui::Control().closeDialog();
-        }
-        else {
-            ViewProviderGeometryObject::unsetEdit(ModNum);
-        }
+        printf("unset 2\n");
+        ViewProviderGeometryObject::unsetEdit(ModNum);
     }
 }
 
@@ -316,65 +301,6 @@ PyObject* ViewProviderFemConstraint::getPyObject()
 }
 
 
-QObject* ViewProviderFemConstraint::findChildByName(const QObject* parent, const QString& name)
-{
-    for (auto o : parent->children()) {
-        if (o->objectName() == name) {
-            return o;
-        }
-        if (!o->children().empty()) {
-            QObject* result = findChildByName(o, name);
-            if (result) {
-                return result;
-            }
-        }
-    }
-
-    return nullptr;
-}
-
-void ViewProviderFemConstraint::checkForWizard()
-{
-    wizardWidget = nullptr;
-    wizardSubLayout = nullptr;
-    Gui::MainWindow* mw = Gui::getMainWindow();
-    if (!mw) {
-        return;
-    }
-    QDockWidget* dw = mw->findChild<QDockWidget*>(QString::fromLatin1("Combo View"));
-    if (!dw) {
-        return;
-    }
-    QWidget* cw = dw->findChild<QWidget*>(QString::fromLatin1("Combo View"));
-    if (!cw) {
-        return;
-    }
-    QTabWidget* tw = cw->findChild<QTabWidget*>(QString::fromLatin1("combiTab"));
-    if (!tw) {
-        return;
-    }
-    QStackedWidget* sw =
-        tw->findChild<QStackedWidget*>(QString::fromLatin1("qt_tabwidget_stackedwidget"));
-    if (!sw) {
-        return;
-    }
-    QScrollArea* sa = sw->findChild<QScrollArea*>();
-    if (!sa) {
-        return;
-    }
-    QWidget* wd =
-        sa->widget();  // This is the reason why we cannot use findChildByName() right away!!!
-    if (!wd) {
-        return;
-    }
-    QObject* wiz = findChildByName(wd, QString::fromLatin1("ShaftWizard"));
-    if (wiz) {
-        wizardWidget = static_cast<QVBoxLayout*>(wiz);
-        wizardSubLayout = wiz->findChild<QVBoxLayout*>(QString::fromLatin1("ShaftWizardLayout"));
-    }
-}
-
-
 // Python feature -----------------------------------------------------------------------
 
 namespace Gui

src/Mod/Fem/Gui/ViewProviderFemConstraint.h

@@ -112,15 +112,9 @@ class FemGuiExport ViewProviderFemConstraint: public Gui::ViewProviderGeometryOb
 
     static std::string resourceSymbolDir;
 
-    // Shaft design wizard integration
 protected:
     friend class TaskFemConstraint;
-    QVBoxLayout* wizardWidget;
-    QVBoxLayout* wizardSubLayout;
     TaskFemConstraint* constraintDialog;
-
-    void checkForWizard();
-    static QObject* findChildByName(const QObject* parent, const QString& name);
 };
 
 

src/Mod/Fem/Gui/ViewProviderFemConstraintBearing.cpp

@@ -27,7 +27,6 @@
 #include <Inventor/SbRotation.h>
 #include <Inventor/SbVec3f.h>
 #include <Inventor/nodes/SoSeparator.h>
-#include <QMessageBox>
 #endif
 
 #include "Gui/Control.h"
@@ -52,60 +51,33 @@ ViewProviderFemConstraintBearing::~ViewProviderFemConstraintBearing() = default;
 
 bool ViewProviderFemConstraintBearing::setEdit(int ModNum)
 {
-
     if (ModNum == ViewProvider::Default) {
         // When double-clicking on the item for this constraint the
         // object unsets and sets its edit mode without closing
         // the task panel
         Gui::TaskView::TaskDialog* dlg = Gui::Control().activeDialog();
-        TaskDlgFemConstraintBearing* constrDlg = qobject_cast<TaskDlgFemConstraintBearing*>(dlg);
-        if (constrDlg && constrDlg->getConstraintView() != this) {
-            constrDlg = nullptr;  // another constraint left open its task panel
+        TaskDlgFemConstraint* constrDlg = qobject_cast<TaskDlgFemConstraint*>(dlg);
+        if (constrDlg
+            && constrDlg->getConstraintView() == static_cast<ViewProviderFemConstraint*>(this)) {
+            return false;
         }
-        if (dlg && !constrDlg) {
-            // This case will occur in the ShaftWizard application
-            checkForWizard();
-            if (!wizardWidget || !wizardSubLayout) {
-                // No shaft wizard is running
-                QMessageBox msgBox;
-                msgBox.setText(QObject::tr("A dialog is already open in the task panel"));
-                msgBox.setInformativeText(QObject::tr("Do you want to close this dialog?"));
-                msgBox.setStandardButtons(QMessageBox::Yes | QMessageBox::No);
-                msgBox.setDefaultButton(QMessageBox::Yes);
-                int ret = msgBox.exec();
-                if (ret == QMessageBox::Yes) {
-                    Gui::Control().reject();
-                }
-                else {
-                    return false;
-                }
-            }
-            else if (constraintDialog) {
-                // Another FemConstraint* dialog is already open inside the Shaft Wizard
-                // Ignore the request to open another dialog
-                return false;
+        if (dlg) {
+            if (dlg->canClose()) {
+                Gui::Control().reject();
             }
             else {
-                constraintDialog = new TaskFemConstraintBearing(this);
-                return true;
+                return false;
             }
         }
 
         // clear the selection (convenience)
         Gui::Selection().clearSelection();
-
-        // start the edit dialog
-        if (constrDlg) {
-            Gui::Control().showDialog(constrDlg);
-        }
-        else {
-            Gui::Control().showDialog(new TaskDlgFemConstraintBearing(this));
-        }
+        Gui::Control().showDialog(new TaskDlgFemConstraintBearing(this));
 
         return true;
     }
     else {
-        return ViewProviderDocumentObject::setEdit(ModNum);  // clazy:exclude=skipped-base-method
+        return ViewProviderFemConstraint::setEdit(ModNum);
     }
 }
 

src/Mod/Fem/Gui/ViewProviderFemConstraintContact.cpp

@@ -57,35 +57,28 @@ bool ViewProviderFemConstraintContact::setEdit(int ModNum)
         // object unsets and sets its edit mode without closing
         // the task panel
         Gui::TaskView::TaskDialog* dlg = Gui::Control().activeDialog();
-        TaskDlgFemConstraintContact* constrDlg = qobject_cast<TaskDlgFemConstraintContact*>(dlg);
-        if (constrDlg && constrDlg->getConstraintView() != this) {
-            constrDlg = nullptr;  // another constraint left open its task panel
+        TaskDlgFemConstraint* constrDlg = qobject_cast<TaskDlgFemConstraint*>(dlg);
+        if (constrDlg
+            && constrDlg->getConstraintView() == static_cast<ViewProviderFemConstraint*>(this)) {
+            return false;
         }
-        if (dlg && !constrDlg) {
-            if (constraintDialog) {
-                // Ignore the request to open another dialog
-                return false;
+        if (dlg) {
+            if (dlg->canClose()) {
+                Gui::Control().reject();
             }
             else {
-                constraintDialog = new TaskFemConstraintContact(this);
-                return true;
+                return false;
             }
         }
 
         // clear the selection (convenience)
         Gui::Selection().clearSelection();
+        Gui::Control().showDialog(new TaskDlgFemConstraintContact(this));
 
-        // start the edit dialog
-        if (constrDlg) {
-            Gui::Control().showDialog(constrDlg);
-        }
-        else {
-            Gui::Control().showDialog(new TaskDlgFemConstraintContact(this));
-        }
         return true;
     }
     else {
-        return ViewProviderDocumentObject::setEdit(ModNum);  // clazy:exclude=skipped-base-method
+        return ViewProviderFemConstraint::setEdit(ModNum);
     }
 }