.has(/* nothing */) should be true

[fiatjaf]

code on

object-path/index.js

Lines 160 to 162 in c540af3

	if (isEmpty(path) || path.length === 0) {
	return false;
	}

for the .has() method:

    if (isEmpty(path) || path.length === 0) {
      return false;
    }

If we are searching for an empty key and the variable being searched is an object, then it is intuitive that the object has that. It can perhaps miss all keys in the world as long as long as they have a name, but for keys with no name any object has all.

[fiatjaf]

In fact, it is the same rationale for .get, which is implemented the intuitive way (code).

For example:

var a = {x: 123}

objectPath.get(a, 'x') // 123
objectPath.has(a, 'x') // true

objectPath.get(a) // {x: 123}
objectPath.has(a) // false -- why?

Do you agree this is a discrepancy?

[mariocasciaro]

I agree with you, there is a discrepancy between the two methods which might easily result in defects in the code. We are currently evaluating if the fix should be in the get method rather than in the has method. Please join the discussion here #62