-
Notifications
You must be signed in to change notification settings - Fork 48
Code cleanup #59
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
There are many parts of the code that could do with a bit of cleaning up. I would very much appreciate any help on this, I can help out by reviewing any changes:
The script includes multiple ways of reading properties:
while readingetNicknameFromPropgreppipe everywhere elseThe first actually seems more robust, but the second is more "bash"-y. I don't really care, anyway. The point is that they should be consistent.
getNicknameis quite messy. Theifstatements could surely be simplified in some way. Or it should be commented internally, at least.Overall, many commands are incredibly large and complicated. We could:
\so that it's more readablePut all the simple getter functions at the beginning of the file
If anyone else thinks of other improvements, please leave them as a comment here!