Commit 5821262
fix(pooled): throw ObjectDisposedException from Count/Keys/Values after Dispose
PooledCelerityDictionary and PooledCeleritySet document that "after Dispose
every member throws ObjectDisposedException", but the read accessors Count
(both types) and Keys / Values (dictionary) skipped ThrowIfDisposed(). Since
Dispose zeroes _count and returns the backing arrays to ArrayPool.Shared, a
post-dispose read returned a silent, misleading result (0, or an empty view)
over buffers the pool may have re-handed out. Gate all three on
ThrowIfDisposed() so the code matches the documented contract, and extend the
UseAfterDispose regression tests to cover them.
Closes #296
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent b48cd75 commit 5821262
5 files changed
Lines changed: 54 additions & 4 deletions
File tree
- src
- Celerity.Tests/Collections
- Celerity/Collections
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
11 | 15 | | |
12 | 16 | | |
13 | 17 | | |
| |||
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
277 | 286 | | |
278 | 287 | | |
279 | 288 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
236 | 241 | | |
237 | 242 | | |
238 | 243 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
206 | 214 | | |
207 | 215 | | |
208 | 216 | | |
| |||
619 | 627 | | |
620 | 628 | | |
621 | 629 | | |
622 | | - | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
623 | 639 | | |
624 | 640 | | |
625 | 641 | | |
626 | 642 | | |
627 | 643 | | |
628 | | - | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
629 | 653 | | |
630 | 654 | | |
631 | 655 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
196 | 204 | | |
197 | 205 | | |
198 | 206 | | |
| |||
0 commit comments