From e5c74ba3e14a14d695e690e3a8f08a284225c7fa Mon Sep 17 00:00:00 2001 From: Marius Bughiu Date: Sat, 18 Jul 2026 18:15:06 +0300 Subject: [PATCH] docs(hashing): fix misquoted note in StringFnV1AFullHasher (#254) The XML doc for StringFnV1AFullHasher quoted StringFnV1AHasher's remarks as "for keys with significant non-ASCII content, a full UTF-8 or UTF-16 hash is preferable." That wording is a conflation of two hashers: the phrase "for keys with significant non-ASCII content" actually comes from StringMurmur3Hasher, not StringFnV1AHasher. Replace it with the verbatim note from StringFnV1AHasher: "For Unicode-heavy workloads, a full UTF-8 or UTF-16 hash is preferable." Co-Authored-By: Claude Opus 4.8 --- src/Celerity.Hashing/StringFnV1AFullHasher.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Celerity.Hashing/StringFnV1AFullHasher.cs b/src/Celerity.Hashing/StringFnV1AFullHasher.cs index 9df7cb1..d4ebc4f 100644 --- a/src/Celerity.Hashing/StringFnV1AFullHasher.cs +++ b/src/Celerity.Hashing/StringFnV1AFullHasher.cs @@ -9,8 +9,8 @@ namespace Celerity.Hashing; /// /// /// This is the full-character-width counterpart to , -/// and directly answers the note in that hasher's remarks that "for keys with -/// significant non-ASCII content, a full UTF-8 or UTF-16 hash is preferable." +/// and directly answers the note in that hasher's remarks that "For Unicode-heavy +/// workloads, a full UTF-8 or UTF-16 hash is preferable." /// Where folds only the low byte of each /// character (c & 0xFF) and therefore cannot distinguish characters /// that differ only in their upper byte — for example 'A' (U+0041)