Merge pull request #24 from mariuspruvot/ci/pipeline-improvements

ci: add mypy, coverage threshold, and claude-runner build

Author: mariuspruvot

.github/workflows/ci.yml

@@ -18,6 +18,7 @@ jobs:
       - run: uv sync --frozen
       - run: uv run ruff check src/ tests/
       - run: uv run ruff format --check src/ tests/
+      - run: uv run mypy src/
 
   test-backend:
     runs-on: ubuntu-latest
@@ -42,7 +43,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: astral-sh/setup-uv@v4
       - run: uv sync --frozen
-      - run: uv run pytest
+      - run: uv run pytest --cov=helprs --cov-report=term-missing --cov-fail-under=70
         env:
           DATABASE_URL: postgresql+asyncpg://helprs:helprs@localhost:5432/helprs_test
           SECRET_KEY: ci-test-secret-key
@@ -87,3 +88,4 @@ jobs:
       - uses: actions/checkout@v4
       - run: docker build -f infra/docker/Dockerfile.api --target production apps/api
       - run: docker build -f infra/docker/Dockerfile.web --target production apps/web
+      - run: docker build -f infra/docker/claude-runner/Dockerfile infra/docker/claude-runner

Makefile

@@ -1,13 +1,17 @@
-.PHONY: dev lint test build build-runner migrate types
+.PHONY: dev lint test build build-runner migrate types typecheck
 
 dev:
 	docker compose up --build
 
 lint:
 	cd apps/api && uv run ruff check src/ tests/
 	cd apps/api && uv run ruff format --check src/ tests/
+	cd apps/api && uv run mypy src/
 	cd apps/web && npx eslint src/
 
+typecheck:
+	cd apps/api && uv run mypy src/
+
 test:
 	cd apps/api && uv run pytest
 	cd apps/web && npx vitest run

README.md

@@ -1,5 +1,7 @@
 # helPRs
 
+[![CI](https://github.com/mariuspruvot/helprs/actions/workflows/ci.yml/badge.svg)](https://github.com/mariuspruvot/helprs/actions/workflows/ci.yml)
+
 **Pluggable AI skill runner for pull requests.**
 
 helPRs spins up ephemeral Docker containers running [Claude Code](https://docs.anthropic.com/en/docs/claude-code) to execute skills against your PRs -- comprehension quizzes, code reviews, security audits -- and streams results back in real time.

apps/api/pyproject.toml

@@ -27,7 +27,9 @@ dev = [
     "ruff>=0.8.0",
     "pytest>=8.3.0",
     "pytest-asyncio>=0.24.0",
+    "pytest-cov>=5.0.0",
     "httpx>=0.28.0",
+    "mypy>=1.11.0",
 ]
 
 [build-system]
@@ -44,6 +46,33 @@ line-length = 120
 [tool.ruff.lint]
 select = ["E", "F", "I", "N", "UP", "B", "A", "SIM", "TCH"]
 
+[tool.mypy]
+python_version = "3.12"
+warn_unused_configs = true
+ignore_missing_imports = true
+plugins = ["pydantic.mypy"]
+
+[tool.pydantic-mypy]
+init_forbid_extra = true
+init_typed = true
+
+# Per-module overrides for third-party lib typing issues (aiodocker, SQLAlchemy, Starlette)
+[[tool.mypy.overrides]]
+module = ["helprs.modules.container.*", "helprs.main"]
+disable_error_code = ["arg-type", "call-overload", "attr-defined"]
+
+[[tool.mypy.overrides]]
+module = ["helprs.core.middleware"]
+disable_error_code = ["arg-type"]
+
+[[tool.mypy.overrides]]
+module = ["helprs.modules.webhook.repository", "helprs.modules.webhook.verification"]
+disable_error_code = ["attr-defined", "arg-type"]
+
+[[tool.mypy.overrides]]
+module = ["helprs.modules.installation.service"]
+disable_error_code = ["arg-type"]
+
 [tool.pytest.ini_options]
 asyncio_mode = "auto"
 testpaths = ["tests"]

apps/api/tests/modules/webhook/test_dispatcher.py

@@ -2,12 +2,25 @@
 
 from unittest.mock import AsyncMock, patch
 
+import pytest
 import structlog
 
 from helprs.modules.webhook import dispatcher
 from helprs.modules.webhook.dispatcher import DispatchResult
 
 
+@pytest.fixture(autouse=True)
+def _reset_dispatcher_logger():
+    """Clear cached bound logger so structlog.testing.capture_logs() works.
+
+    create_app() calls configure_logging() with cache_logger_on_first_use=True.
+    Once the module-level logger proxy in dispatcher.py resolves and caches its
+    bound logger, capture_logs() can no longer intercept it.  Replacing the proxy
+    with a fresh one before each test fixes this.
+    """
+    dispatcher.logger = structlog.get_logger()
+
+
 class TestDispatchWebhook:
     async def test_installation_created_routes_to_handler(self, db_session):
         mock_handler = AsyncMock()