|
| 1 | +"""Tests for scorecard extraction from Claude session output.""" |
| 2 | + |
| 3 | +from helprs.modules.container.scorecard import extract_scorecard |
| 4 | + |
| 5 | + |
| 6 | +VALID_SCORECARD = """\ |
| 7 | +Some assistant text before the scorecard. |
| 8 | +
|
| 9 | +```helprs-scorecard |
| 10 | +{ |
| 11 | + "skill": "challenge-me", |
| 12 | + "version": 1, |
| 13 | + "questions_asked": 3, |
| 14 | + "questions_answered": 3, |
| 15 | + "dimensions": { |
| 16 | + "depth": 8, |
| 17 | + "clarity": 7, |
| 18 | + "rigor": 6 |
| 19 | + }, |
| 20 | + "summary": "Strong understanding of failure modes.", |
| 21 | + "highlights": ["Good instinct on idempotency"] |
| 22 | +} |
| 23 | +``` |
| 24 | +
|
| 25 | +Some text after. |
| 26 | +""" |
| 27 | + |
| 28 | + |
| 29 | +def test_extract_valid_scorecard(): |
| 30 | + result = extract_scorecard(VALID_SCORECARD) |
| 31 | + assert result is not None |
| 32 | + assert result["skill"] == "challenge-me" |
| 33 | + assert result["version"] == 1 |
| 34 | + assert result["dimensions"] == {"depth": 8, "clarity": 7, "rigor": 6} |
| 35 | + assert result["summary"] == "Strong understanding of failure modes." |
| 36 | + assert result["highlights"] == ["Good instinct on idempotency"] |
| 37 | + |
| 38 | + |
| 39 | +def test_extract_returns_none_when_no_block(): |
| 40 | + assert extract_scorecard("Just some regular text without a scorecard") is None |
| 41 | + |
| 42 | + |
| 43 | +def test_extract_returns_none_for_invalid_json(): |
| 44 | + text = "```helprs-scorecard\n{invalid json}\n```" |
| 45 | + assert extract_scorecard(text) is None |
| 46 | + |
| 47 | + |
| 48 | +def test_extract_returns_none_for_missing_required_fields(): |
| 49 | + text = '```helprs-scorecard\n{"skill": "challenge-me"}\n```' |
| 50 | + assert extract_scorecard(text) is None |
| 51 | + |
| 52 | + |
| 53 | +def test_extract_returns_none_for_wrong_dimension_count(): |
| 54 | + text = """```helprs-scorecard |
| 55 | +{ |
| 56 | + "skill": "challenge-me", |
| 57 | + "version": 1, |
| 58 | + "dimensions": {"depth": 8, "clarity": 7}, |
| 59 | + "summary": "Missing one dimension" |
| 60 | +} |
| 61 | +```""" |
| 62 | + assert extract_scorecard(text) is None |
| 63 | + |
| 64 | + |
| 65 | +def test_extract_returns_none_for_out_of_range_scores(): |
| 66 | + text = """```helprs-scorecard |
| 67 | +{ |
| 68 | + "skill": "challenge-me", |
| 69 | + "version": 1, |
| 70 | + "dimensions": {"depth": 11, "clarity": 7, "rigor": 6}, |
| 71 | + "summary": "Score out of range" |
| 72 | +} |
| 73 | +```""" |
| 74 | + assert extract_scorecard(text) is None |
| 75 | + |
| 76 | + |
| 77 | +def test_extract_returns_none_for_negative_scores(): |
| 78 | + text = """```helprs-scorecard |
| 79 | +{ |
| 80 | + "skill": "challenge-me", |
| 81 | + "version": 1, |
| 82 | + "dimensions": {"depth": -1, "clarity": 7, "rigor": 6}, |
| 83 | + "summary": "Negative score" |
| 84 | +} |
| 85 | +```""" |
| 86 | + assert extract_scorecard(text) is None |
| 87 | + |
| 88 | + |
| 89 | +def test_extract_handles_float_scores(): |
| 90 | + text = """```helprs-scorecard |
| 91 | +{ |
| 92 | + "skill": "eli5", |
| 93 | + "version": 1, |
| 94 | + "dimensions": {"accuracy": 7.5, "simplicity": 8.0, "completeness": 6.5}, |
| 95 | + "summary": "Good explanation" |
| 96 | +} |
| 97 | +```""" |
| 98 | + result = extract_scorecard(text) |
| 99 | + assert result is not None |
| 100 | + assert result["dimensions"]["accuracy"] == 7.5 |
| 101 | + |
| 102 | + |
| 103 | +def test_extract_handles_different_skill_dimensions(): |
| 104 | + text = """```helprs-scorecard |
| 105 | +{ |
| 106 | + "skill": "pair-debug", |
| 107 | + "version": 1, |
| 108 | + "dimensions": {"detection": 9, "methodology": 7, "speed": 8}, |
| 109 | + "summary": "Found the bug quickly" |
| 110 | +} |
| 111 | +```""" |
| 112 | + result = extract_scorecard(text) |
| 113 | + assert result is not None |
| 114 | + assert result["skill"] == "pair-debug" |
| 115 | + assert set(result["dimensions"].keys()) == {"detection", "methodology", "speed"} |
0 commit comments