forked from rtk-ai/rtk
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathfind_cmd.rs
More file actions
650 lines (558 loc) · 19.7 KB
/
Copy pathfind_cmd.rs
File metadata and controls
650 lines (558 loc) · 19.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
//! Filters find results by grouping files by directory.
use crate::core::tracking;
use anyhow::{Context, Result};
use ignore::WalkBuilder;
use std::collections::HashMap;
use std::path::Path;
/// Match a filename against a glob pattern (supports `*` and `?`).
fn glob_match(pattern: &str, name: &str) -> bool {
glob_match_inner(pattern.as_bytes(), name.as_bytes())
}
fn glob_match_inner(pat: &[u8], name: &[u8]) -> bool {
match (pat.first(), name.first()) {
(None, None) => true,
(Some(b'*'), _) => {
// '*' matches zero or more characters
glob_match_inner(&pat[1..], name)
|| (!name.is_empty() && glob_match_inner(pat, &name[1..]))
}
(Some(b'?'), Some(_)) => glob_match_inner(&pat[1..], &name[1..]),
(Some(&p), Some(&n)) if p == n => glob_match_inner(&pat[1..], &name[1..]),
_ => false,
}
}
/// Parsed arguments from either native find or RTK find syntax.
#[derive(Debug)]
struct FindArgs {
pattern: String,
path: String,
max_results: usize,
max_depth: Option<usize>,
file_type: String,
case_insensitive: bool,
}
impl Default for FindArgs {
fn default() -> Self {
Self {
pattern: "*".to_string(),
path: ".".to_string(),
max_results: 50,
max_depth: None,
file_type: "f".to_string(),
case_insensitive: false,
}
}
}
/// Consume the next argument from `args` at position `i`, advancing the index.
/// Returns `None` if `i` is past the end of `args`.
fn next_arg(args: &[String], i: &mut usize) -> Option<String> {
*i += 1;
args.get(*i).cloned()
}
/// Check if args contain native find flags (-name, -type, -maxdepth, etc.)
fn has_native_find_flags(args: &[String]) -> bool {
args.iter()
.any(|a| a == "-name" || a == "-type" || a == "-maxdepth" || a == "-iname")
}
/// Native find features RTK's structured walker can't model faithfully:
/// compound predicates (-not/-or/-and), actions (-exec/-delete/-print0), and
/// time/size/perm tests. When any appear, `run_from_args` falls back to the
/// real `find` (passthrough) instead of blocking the user.
const UNSUPPORTED_FIND_FLAGS: &[&str] = &[
"-not", "!", "-or", "-o", "-and", "-a", "-exec", "-execdir", "-delete", "-print0", "-newer",
"-perm", "-size", "-mtime", "-mmin", "-atime", "-amin", "-ctime", "-cmin", "-empty", "-link",
"-regex", "-iregex",
];
fn has_unsupported_find_flags(args: &[String]) -> bool {
args.iter()
.any(|a| UNSUPPORTED_FIND_FLAGS.contains(&a.as_str()))
}
/// Parse arguments from raw args vec, supporting both native find and RTK syntax.
///
/// Native find syntax: `find . -name "*.rs" -type f -maxdepth 3`
/// RTK syntax: `find *.rs [path] [-m max] [-t type]`
fn parse_find_args(args: &[String]) -> Result<FindArgs> {
if args.is_empty() {
return Ok(FindArgs::default());
}
if has_native_find_flags(args) {
parse_native_find_args(args)
} else {
parse_rtk_find_args(args)
}
}
/// Parse native find syntax: `find [path] -name "*.rs" -type f -maxdepth 3`
fn parse_native_find_args(args: &[String]) -> Result<FindArgs> {
let mut parsed = FindArgs::default();
let mut i = 0;
// First non-flag argument is the path (standard find behavior)
if !args[0].starts_with('-') {
parsed.path = args[0].clone();
i = 1;
}
while i < args.len() {
match args[i].as_str() {
"-name" => {
if let Some(val) = next_arg(args, &mut i) {
parsed.pattern = val;
}
}
"-iname" => {
if let Some(val) = next_arg(args, &mut i) {
parsed.pattern = val;
parsed.case_insensitive = true;
}
}
"-type" => {
if let Some(val) = next_arg(args, &mut i) {
parsed.file_type = val;
}
}
"-maxdepth" => {
if let Some(val) = next_arg(args, &mut i) {
parsed.max_depth = Some(val.parse().context("invalid -maxdepth value")?);
}
}
flag if flag.starts_with('-') => {
eprintln!("rtk find: unknown flag '{}', ignored", flag);
}
_ => {}
}
i += 1;
}
Ok(parsed)
}
/// Parse RTK syntax: `find <pattern> [path] [-m max] [-t type]`
fn parse_rtk_find_args(args: &[String]) -> Result<FindArgs> {
let mut parsed = FindArgs {
pattern: args[0].clone(),
..FindArgs::default()
};
let mut i = 1;
// Second positional arg (if not a flag) is the path
if i < args.len() && !args[i].starts_with('-') {
parsed.path = args[i].clone();
i += 1;
}
while i < args.len() {
match args[i].as_str() {
"-m" | "--max" => {
if let Some(val) = next_arg(args, &mut i) {
parsed.max_results = val.parse().context("invalid --max value")?;
}
}
"-t" | "--file-type" => {
if let Some(val) = next_arg(args, &mut i) {
parsed.file_type = val;
}
}
_ => {}
}
i += 1;
}
Ok(parsed)
}
/// Entry point from main.rs — parses raw args then delegates to run().
///
/// When args use native find features RTK can't represent (compound predicates,
/// actions like -exec/-delete, time/size/perm tests) we fall back to the real
/// `find` unchanged rather than erroring — RTK's mandated fallback pattern.
pub fn run_from_args(args: &[String], verbose: u8) -> Result<i32> {
if has_unsupported_find_flags(args) {
return passthrough_find(args, verbose);
}
let parsed = parse_find_args(args)?;
run(
&parsed.pattern,
&parsed.path,
parsed.max_results,
parsed.max_depth,
&parsed.file_type,
parsed.case_insensitive,
verbose,
)?;
Ok(0)
}
/// Run the real `find` unchanged, streaming output and tracking at 0% savings.
/// Used when args contain features RTK's structured filter can't represent
/// (e.g. -exec, -not, -delete). Mirrors the underlying exit code.
fn passthrough_find(args: &[String], verbose: u8) -> Result<i32> {
let os_args: Vec<std::ffi::OsString> =
args.iter().map(std::ffi::OsString::from).collect();
crate::core::runner::run_passthrough("find", &os_args, verbose)
}
pub fn run(
pattern: &str,
path: &str,
max_results: usize,
max_depth: Option<usize>,
file_type: &str,
case_insensitive: bool,
verbose: u8,
) -> Result<()> {
let timer = tracking::TimedExecution::start();
// Treat "." as match-all
let effective_pattern = if pattern == "." { "*" } else { pattern };
if verbose > 0 {
eprintln!("find: {} in {}", effective_pattern, path);
}
let want_dirs = file_type == "d";
// When the pattern targets dotfiles (e.g. -name ".claude.json"), we must walk hidden
// entries; otherwise skip them to keep results tidy (#1101).
let search_hidden = effective_pattern.starts_with('.');
let mut builder = WalkBuilder::new(path);
builder
.hidden(!search_hidden) // skip hidden files/dirs unless pattern targets dotfiles
.git_ignore(true) // respect .gitignore
.git_global(true)
.git_exclude(true);
if let Some(depth) = max_depth {
builder.max_depth(Some(depth));
}
let walker = builder.build();
let mut files: Vec<String> = Vec::new();
for entry in walker {
let entry = match entry {
Ok(e) => e,
Err(_) => continue,
};
let ft = entry.file_type();
let is_dir = ft.as_ref().is_some_and(|t| t.is_dir());
// Filter by type
if want_dirs && !is_dir {
continue;
}
if !want_dirs && is_dir {
continue;
}
let entry_path = entry.path();
// Get filename for glob matching
let name = match entry_path.file_name() {
Some(n) => n.to_string_lossy(),
None => continue,
};
let matches = if case_insensitive {
glob_match(&effective_pattern.to_lowercase(), &name.to_lowercase())
} else {
glob_match(effective_pattern, &name)
};
if !matches {
continue;
}
// Store path relative to search root
let display_path = entry_path
.strip_prefix(path)
.unwrap_or(entry_path)
.to_string_lossy()
.to_string();
if !display_path.is_empty() {
files.push(display_path);
}
}
files.sort();
let raw_output = files.join("\n");
if files.is_empty() {
let msg = format!("0 for '{}'", effective_pattern);
println!("{}", msg);
timer.track(
&format!("find {} -name '{}'", path, effective_pattern),
"rtk find",
&raw_output,
&msg,
);
return Ok(());
}
// Group by directory
let mut by_dir: HashMap<String, Vec<String>> = HashMap::new();
for file in &files {
let p = Path::new(file);
let dir = p
.parent()
.map(|d| d.to_string_lossy().to_string())
.unwrap_or_else(|| ".".to_string());
let dir = if dir.is_empty() { ".".to_string() } else { dir };
let filename = p
.file_name()
.map(|f| f.to_string_lossy().to_string())
.unwrap_or_default();
by_dir.entry(dir).or_default().push(filename);
}
let mut dirs: Vec<_> = by_dir.keys().cloned().collect();
dirs.sort();
let dirs_count = dirs.len();
let total_files = files.len();
println!("{}F {}D:", total_files, dirs_count);
println!();
// Display with proper --max limiting (count individual files)
let mut shown = 0;
for dir in &dirs {
if shown >= max_results {
break;
}
let files_in_dir = &by_dir[dir];
let dir_display = if dir.len() > 50 {
format!("...{}", &dir[dir.len() - 47..])
} else {
dir.clone()
};
let remaining_budget = max_results - shown;
if files_in_dir.len() <= remaining_budget {
println!("{}/ {}", dir_display, files_in_dir.join(" "));
shown += files_in_dir.len();
} else {
// Partial display: show only what fits in budget
let partial: Vec<_> = files_in_dir
.iter()
.take(remaining_budget)
.cloned()
.collect();
println!("{}/ {}", dir_display, partial.join(" "));
shown += partial.len();
break;
}
}
if shown < total_files {
println!("+{} more", total_files - shown);
}
// Extension summary
let mut by_ext: HashMap<String, usize> = HashMap::new();
for file in &files {
let ext = Path::new(file)
.extension()
.map(|e| e.to_string_lossy().to_string())
.unwrap_or_else(|| "none".to_string());
*by_ext.entry(ext).or_default() += 1;
}
let mut ext_line = String::new();
if by_ext.len() > 1 {
println!();
let mut exts: Vec<_> = by_ext.iter().collect();
exts.sort_by(|a, b| b.1.cmp(a.1));
let ext_str: Vec<String> = exts
.iter()
.take(5)
.map(|(e, c)| format!(".{}({})", e, c))
.collect();
ext_line = format!("ext: {}", ext_str.join(" "));
println!("{}", ext_line);
}
let rtk_output = format!("{}F {}D + {}", total_files, dirs_count, ext_line);
timer.track(
&format!("find {} -name '{}'", path, effective_pattern),
"rtk find",
&raw_output,
&rtk_output,
);
Ok(())
}
#[cfg(test)]
mod tests {
use super::*;
/// Convert string slices to Vec<String> for test convenience.
fn args(values: &[&str]) -> Vec<String> {
values.iter().map(|s| s.to_string()).collect()
}
// --- glob_match unit tests ---
#[test]
fn glob_match_star_rs() {
assert!(glob_match("*.rs", "main.rs"));
assert!(glob_match("*.rs", "find_cmd.rs"));
assert!(!glob_match("*.rs", "main.py"));
assert!(!glob_match("*.rs", "rs"));
}
#[test]
fn glob_match_star_all() {
assert!(glob_match("*", "anything.txt"));
assert!(glob_match("*", "a"));
assert!(glob_match("*", ".hidden"));
}
#[test]
fn glob_match_question_mark() {
assert!(glob_match("?.rs", "a.rs"));
assert!(!glob_match("?.rs", "ab.rs"));
}
#[test]
fn glob_match_exact() {
assert!(glob_match("Cargo.toml", "Cargo.toml"));
assert!(!glob_match("Cargo.toml", "cargo.toml"));
}
#[test]
fn glob_match_complex() {
assert!(glob_match("test_*", "test_foo"));
assert!(glob_match("test_*", "test_"));
assert!(!glob_match("test_*", "test"));
}
// --- dot pattern treated as star ---
#[test]
fn dot_becomes_star() {
// run() converts "." to "*" internally, test the logic
let effective = if "." == "." { "*" } else { "." };
assert_eq!(effective, "*");
}
// --- parse_find_args: native find syntax ---
#[test]
fn parse_native_find_name() {
let parsed = parse_find_args(&args(&[".", "-name", "*.rs"])).unwrap();
assert_eq!(parsed.pattern, "*.rs");
assert_eq!(parsed.path, ".");
assert_eq!(parsed.file_type, "f");
assert_eq!(parsed.max_results, 50);
}
#[test]
fn parse_native_find_name_and_type() {
let parsed = parse_find_args(&args(&["src", "-name", "*.rs", "-type", "f"])).unwrap();
assert_eq!(parsed.pattern, "*.rs");
assert_eq!(parsed.path, "src");
assert_eq!(parsed.file_type, "f");
}
#[test]
fn parse_native_find_type_d() {
let parsed = parse_find_args(&args(&[".", "-type", "d"])).unwrap();
assert_eq!(parsed.pattern, "*");
assert_eq!(parsed.file_type, "d");
}
#[test]
fn parse_native_find_maxdepth() {
let parsed = parse_find_args(&args(&[".", "-name", "*.toml", "-maxdepth", "2"])).unwrap();
assert_eq!(parsed.pattern, "*.toml");
assert_eq!(parsed.max_depth, Some(2));
assert_eq!(parsed.max_results, 50); // max_results unchanged by -maxdepth
}
#[test]
fn parse_native_find_iname() {
let parsed = parse_find_args(&args(&[".", "-iname", "Makefile"])).unwrap();
assert_eq!(parsed.pattern, "Makefile");
assert!(parsed.case_insensitive);
}
#[test]
fn parse_native_find_name_is_case_sensitive() {
let parsed = parse_find_args(&args(&[".", "-name", "*.rs"])).unwrap();
assert!(!parsed.case_insensitive);
}
#[test]
fn parse_native_find_no_path() {
// `find -name "*.rs"` without explicit path defaults to "."
let parsed = parse_find_args(&args(&["-name", "*.rs"])).unwrap();
assert_eq!(parsed.pattern, "*.rs");
assert_eq!(parsed.path, ".");
}
// --- parse_find_args: unsupported flags ---
#[test]
fn unsupported_flags_detected() {
assert!(has_unsupported_find_flags(&args(&[
".", "-name", "*.rs", "-not", "-name", "x"
])));
assert!(has_unsupported_find_flags(&args(&[
".", "-name", "*.tmp", "-exec", "rm", "{}", ";"
])));
assert!(has_unsupported_find_flags(&args(&[".", "-delete"])));
assert!(has_unsupported_find_flags(&args(&[".", "-size", "+1M"])));
}
#[test]
fn supported_flags_not_flagged_as_unsupported() {
assert!(!has_unsupported_find_flags(&args(&[
".", "-name", "*.rs", "-type", "f"
])));
assert!(!has_unsupported_find_flags(&args(&["*.rs", "src", "-m", "10"])));
}
#[test]
fn run_from_args_falls_back_for_unsupported_flags() {
// `-not` is unsupported by the structured parser. Instead of erroring
// (the old behavior), run_from_args must run the real `find` and return
// its exit code. Scoped to src/ with a read-only predicate so it exits 0.
let code = run_from_args(&args(&["src", "-name", "*.rs", "-not", "-name", "zzzzz"]), 0)
.expect("passthrough find should not error");
assert_eq!(code, 0, "successful passthrough find should propagate exit 0");
}
// --- parse_find_args: RTK syntax ---
#[test]
fn parse_rtk_syntax_pattern_only() {
let parsed = parse_find_args(&args(&["*.rs"])).unwrap();
assert_eq!(parsed.pattern, "*.rs");
assert_eq!(parsed.path, ".");
}
#[test]
fn parse_rtk_syntax_pattern_and_path() {
let parsed = parse_find_args(&args(&["*.rs", "src"])).unwrap();
assert_eq!(parsed.pattern, "*.rs");
assert_eq!(parsed.path, "src");
}
#[test]
fn parse_rtk_syntax_with_flags() {
let parsed = parse_find_args(&args(&["*.rs", "src", "-m", "10", "-t", "d"])).unwrap();
assert_eq!(parsed.pattern, "*.rs");
assert_eq!(parsed.path, "src");
assert_eq!(parsed.max_results, 10);
assert_eq!(parsed.file_type, "d");
}
#[test]
fn parse_empty_args() {
let parsed = parse_find_args(&args(&[])).unwrap();
assert_eq!(parsed.pattern, "*");
assert_eq!(parsed.path, ".");
}
// --- run_from_args integration tests ---
#[test]
fn run_from_args_native_find_syntax() {
// Simulates: find . -name "*.rs" -type f
let result = run_from_args(&args(&[".", "-name", "*.rs", "-type", "f"]), 0);
assert!(result.is_ok());
}
#[test]
fn run_from_args_rtk_syntax() {
// Simulates: rtk find *.rs src
let result = run_from_args(&args(&["*.rs", "src"]), 0);
assert!(result.is_ok());
}
#[test]
fn run_from_args_iname_case_insensitive() {
// -iname should match case-insensitively
let result = run_from_args(&args(&[".", "-iname", "cargo.toml"]), 0);
assert!(result.is_ok());
}
// --- #1101: dotfile pattern should not skip hidden files ---
#[test]
fn find_dotfile_pattern_includes_hidden() {
// .gitignore exists at the repo root — must be found when using a dotfile pattern
let result = run(".gitignore", ".", 50, Some(1), "f", false, 0);
assert!(result.is_ok(), "run with dotfile pattern should not error");
}
#[test]
fn find_regular_pattern_skips_hidden() {
// Non-dot pattern should not error (hidden dirs remain skipped)
let result = run("*.rs", "src", 5, None, "f", false, 0);
assert!(result.is_ok());
}
// --- integration: run on this repo ---
#[test]
fn find_rs_files_in_src() {
// Should find .rs files without error
let result = run("*.rs", "src", 100, None, "f", false, 0);
assert!(result.is_ok());
}
#[test]
fn find_dot_pattern_works() {
// "." pattern should not error (was broken before)
let result = run(".", "src", 10, None, "f", false, 0);
assert!(result.is_ok());
}
#[test]
fn find_no_matches() {
let result = run("*.xyz_nonexistent", "src", 50, None, "f", false, 0);
assert!(result.is_ok());
}
#[test]
fn find_respects_max() {
// With max=2, should not error
let result = run("*.rs", "src", 2, None, "f", false, 0);
assert!(result.is_ok());
}
#[test]
fn find_gitignored_excluded() {
// target/ is in .gitignore — files inside should not appear
let result = run("*", ".", 1000, None, "f", false, 0);
assert!(result.is_ok());
// We can't easily capture stdout in unit tests, but at least
// verify it runs without error. The smoke tests verify content.
}
}