Update Dockerfile to improve error handling and optimize package installation

Author: markhazleton

.github/workflows/docker-image.yml

@@ -2,82 +2,76 @@ name: docker-markhazletonsample
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
     paths-ignore:
       - README.md
       - .vscode/**
       - .gitignore
   pull_request:
-    branches: [ main ]
+    branches: [main]
     paths-ignore:
       - README.md
       - .vscode/**
       - .gitignore
-  workflow_dispatch:      
+  workflow_dispatch:
 
 jobs:
-
   build:
-
     runs-on: ubuntu-latest
 
     steps:
-    - name: Checkout
-      uses: actions/checkout@v4
+      - name: Checkout
+        uses: actions/checkout@v4
 
-    - name: Set up QEMU
-      uses: docker/setup-qemu-action@v2
-      with:
-        node-version: 16
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
 
-    - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v3
-      with:
-        node-version: 16
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
 
-    - name: Login to DockerHub
-      uses: docker/login-action@v2
-      with:
-        username: ${{ secrets.DOCKERHUB_USERNAME }}
-        password: ${{ secrets.DOCKERHUB_TOKEN }}
+      - name: Login to DockerHub
+        uses: docker/login-action@v3
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
 
-    - name: Lint Dockerfile
-      run: docker run --rm -i hadolint/hadolint < ./Mwh.Sample.Web/Dockerfile
+      - name: Lint Dockerfile
+        run: docker run --rm -i hadolint/hadolint < ./Mwh.Sample.Web/Dockerfile
 
-    - name: Cache Docker layers
-      id: docker-cache
-      uses: actions/cache@v3
-      with:
-        path: /tmp/.buildx-cache
-        key: ${{ runner.os }}-buildx-${{ github.sha }}-${{ hashFiles('**/Dockerfile', '**/Mwh.Sample.Web/**/*') }}
-        restore-keys: |
-          ${{ runner.os }}-buildx-
+      - name: Cache Docker layers
+        id: docker-cache
+        uses: actions/cache@v4
+        with:
+          path: /tmp/.buildx-cache
+          key: ${{ runner.os }}-buildx-${{ github.sha }}-${{ hashFiles('**/Dockerfile', '**/Mwh.Sample.Web/**/*') }}
+          restore-keys: |
+            ${{ runner.os }}-buildx-
 
-    - name: Show Docker info
-      run: docker info
+      - name: Show Docker info
+        run: docker info
 
-    - name: Show Buildx version
-      run: docker buildx version
+      - name: Show Buildx version
+        run: docker buildx version
 
-    - name: Build and push
-      id: docker_image
-      uses: docker/build-push-action@v5
-      with:
-        context: .
-        file: ./Mwh.Sample.Web/Dockerfile
-        push: true
-        pull: true
-        tags: |
-          ${{ secrets.DOCKERHUB_USERNAME }}/mwhsampleweb:latest
-          ${{ secrets.DOCKERHUB_USERNAME }}/mwhsampleweb:${{ github.run_number }}
-        cache-from: type=local,src=/tmp/.buildx-cache
-        cache-to: type=local,dest=/tmp/.buildx-cache
+      - name: Build and push
+        id: docker_image
+        uses: docker/build-push-action@v5
+        with:
+          context: .
+          file: ./Mwh.Sample.Web/Dockerfile
+          push: true
+          pull: true
+          tags: |
+            ${{ secrets.DOCKERHUB_USERNAME }}/mwhsampleweb:latest
+            ${{ secrets.DOCKERHUB_USERNAME }}/mwhsampleweb:${{ github.run_number }}
+          cache-from: type=local,src=/tmp/.buildx-cache
+          cache-to: type=local,dest=/tmp/.buildx-cache
 
-    - name: Cleanup
-      run: |
-        docker builder prune -f
-        docker system prune -f
+      - name: Cleanup
+        run: |
+          docker builder prune -f
+          docker system prune -f
 
-    - name: Set Docker Image Output
-      run: echo "image=${{ secrets.DOCKERHUB_USERNAME }}/mwhsampleweb:latest" >> $GITHUB_ENV
-      shell: bash
+      - name: Set Docker Image Output
+        run: echo "image=${{ secrets.DOCKERHUB_USERNAME }}/mwhsampleweb:latest" >> $GITHUB_ENV
+        shell: bash

Mwh.Sample.Web/Dockerfile

@@ -8,12 +8,17 @@ EXPOSE 443
 FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build
 WORKDIR /src
 
+# Set shell options for better error handling
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
 # Install Node.js and npm
 RUN apt-get update && \
-    apt-get install -y curl && \
+    apt-get install -y --no-install-recommends curl && \
     curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
-    apt-get install -y nodejs && \
-    npm install -g npm@latest
+    apt-get install -y --no-install-recommends nodejs && \
+    npm install -g npm@latest && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*
 
 # Copy the NuGet configuration and project files
 COPY ["nuget.config", "."]