Merge pull request #30 from tejaycar/master

Major upgrade

Author: tejaycar

.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 .kitchen/
 .kitchen.local.yml
+Berksfile.lock

.kitchen.yml

@@ -11,7 +11,6 @@ platforms:
 
 suites:
 - name: default
-  run_list: 
+  run_list:
   - recipe[minitest-handler]
   - recipe[ssh_test]
-  attributes: {}

.rubocop.yml

@@ -0,0 +1,20 @@
+AlignParameters:
+  Enabled: false
+ClassAndModuleChildren:
+  Enabled: false
+Encoding:
+  Enabled: false
+LineLength:
+  Max: 120
+  Severity: refactor
+HashSyntax:
+  EnforcedStyle: hash_rockets
+ClassLength:
+  Enabled: false
+MethodLength:
+  Max: 25
+  Severity: refactor
+SingleSpaceBeforeFirstArg:
+  Enabled: false
+Documentation:
+  Enabled: false

Berksfile

@@ -1,4 +1,7 @@
+source "https://supermarket.getchef.com"
+
 metadata
 
-cookbook "minitest-handler"
-cookbook "ssh_test", :path => "./test/cookbooks/ssh_test"
+group :test do
+  cookbook "ssh_test", :path => "./test/cookbooks/ssh_test"
+end

Berksfile.lock

@@ -1,19 +1,11 @@
-{
-  "sources": {
-    "ssh": {
-      "path": "."
-    },
-    "minitest-handler": {
-      "locked_version": "0.2.1"
-    },
-    "ssh_test": {
-      "path": "./test/cookbooks/ssh_test"
-    },
-    "chef_handler": {
-      "locked_version": "1.1.4"
-    },
-    "ohai": {
-      "locked_version": "1.0.2"
-    }
-  }
-}
+DEPENDENCIES
+  ssh
+    path: .
+    metadata: true
+  ssh_test
+    path: test/cookbooks/ssh_test
+
+GRAPH
+  ssh (0.10.0)
+  ssh_test (0.2.0)
+    ssh (>= 0.0.0)

Gemfile

@@ -0,0 +1,20 @@
+source 'https://rubygems.org'
+
+group :lint do
+  gem 'foodcritic', '~> 4.0'
+  gem 'rubocop'
+end
+
+group :unit do
+  gem 'chefspec', '~> 4.1'
+  gem 'berkshelf', '~> 3.1'
+end
+
+group 'integration' do
+  gem 'kitchen-docker', '~> 1.5.0'
+  gem 'kitchen-sync'
+  gem 'kitchen-vagrant', '~> 0.11'
+  gem 'minitest-chef-handler'
+  gem 'test-kitchen', '~> 1.2'
+  gem 'vagrant-wrapper'
+end

Gemfile.lock

@@ -0,0 +1,245 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.3.6)
+    ast (2.0.0)
+    astrolabe (1.3.0)
+      parser (>= 2.2.0.pre.3, < 3.0)
+    berkshelf (3.1.5)
+      addressable (~> 2.3.4)
+      berkshelf-api-client (~> 1.2)
+      buff-config (~> 1.0)
+      buff-extensions (~> 1.0)
+      buff-shell_out (~> 0.1)
+      celluloid (~> 0.16.0.pre)
+      celluloid-io (~> 0.16.0.pre)
+      faraday (~> 0.9.0)
+      minitar (~> 0.5.4)
+      octokit (~> 3.0)
+      retryable (~> 1.3.3)
+      ridley (~> 4.0)
+      solve (~> 1.1)
+      thor (~> 0.18)
+    berkshelf-api-client (1.2.0)
+      faraday (~> 0.9.0)
+    buff-config (1.0.1)
+      buff-extensions (~> 1.0)
+      varia_model (~> 0.4)
+    buff-extensions (1.0.0)
+    buff-ignore (1.1.1)
+    buff-ruby_engine (0.1.0)
+    buff-shell_out (0.2.0)
+      buff-ruby_engine (~> 0.1.0)
+    builder (3.2.2)
+    celluloid (0.16.0)
+      timers (~> 4.0.0)
+    celluloid-io (0.16.1)
+      celluloid (>= 0.16.0)
+      nio4r (>= 1.0.0)
+    chef (11.16.4)
+      chef-zero (~> 2.1, >= 2.1.4)
+      diff-lcs (~> 1.2, >= 1.2.4)
+      erubis (~> 2.7)
+      ffi-yajl (~> 1.0)
+      highline (~> 1.6, >= 1.6.9)
+      mime-types (~> 1.16)
+      mixlib-authentication (~> 1.3)
+      mixlib-cli (~> 1.4)
+      mixlib-config (~> 2.0)
+      mixlib-log (~> 1.3)
+      mixlib-shellout (~> 1.4)
+      net-ssh (~> 2.6)
+      net-ssh-multi (~> 1.1)
+      ohai (~> 7.4)
+      plist (~> 3.1.0)
+      pry (~> 0.9)
+      rest-client (>= 1.0.4, <= 1.6.7)
+    chef-zero (2.2)
+      hashie (~> 2.0)
+      json
+      mixlib-log (~> 1.3)
+      rack
+    chefspec (4.1.1)
+      chef (>= 11.14)
+      fauxhai (~> 2.0)
+      rspec (~> 3.0)
+    ci_reporter (1.9.3)
+      builder (>= 2.1.2)
+    coderay (1.1.0)
+    dep-selector-libgecode (1.0.2)
+    dep_selector (1.0.3)
+      dep-selector-libgecode (~> 1.0)
+      ffi (~> 1.9)
+    diff-lcs (1.2.5)
+    erubis (2.7.0)
+    faraday (0.9.0)
+      multipart-post (>= 1.2, < 3)
+    fauxhai (2.2.0)
+      net-ssh
+      ohai
+    ffi (1.9.6)
+    ffi-yajl (1.2.0)
+      ffi (~> 1.5)
+      libyajl2 (~> 1.0)
+    foodcritic (4.0.0)
+      erubis
+      gherkin (~> 2.11)
+      nokogiri (~> 1.5)
+      rake
+      rufus-lru (~> 1.0)
+      treetop (~> 1.4)
+      yajl-ruby (~> 1.1)
+    gherkin (2.12.2)
+      multi_json (~> 1.3)
+    hashie (2.1.2)
+    highline (1.6.21)
+    hitimes (1.2.2)
+    ipaddress (0.8.0)
+    json (1.8.1)
+    kitchen-docker (1.5.0)
+      test-kitchen (>= 1.0.0)
+    kitchen-sync (1.0.1)
+      net-sftp
+      test-kitchen (>= 1.0.0)
+    kitchen-vagrant (0.15.0)
+      test-kitchen (~> 1.0)
+    libyajl2 (1.1.0)
+    method_source (0.8.2)
+    mime-types (1.25.1)
+    mini_portile (0.6.0)
+    minitar (0.5.4)
+    minitest (4.7.5)
+    minitest-chef-handler (1.0.3)
+      chef (>= 10.12.0)
+      ci_reporter (< 2.0)
+      minitest (~> 4.7.3)
+    mixlib-authentication (1.3.0)
+      mixlib-log
+    mixlib-cli (1.5.0)
+    mixlib-config (2.1.0)
+    mixlib-log (1.6.0)
+    mixlib-shellout (1.6.0)
+    multi_json (1.10.1)
+    multipart-post (2.0.0)
+    net-http-persistent (2.9.4)
+    net-scp (1.2.1)
+      net-ssh (>= 2.6.5)
+    net-sftp (2.1.2)
+      net-ssh (>= 2.6.5)
+    net-ssh (2.9.1)
+    net-ssh-gateway (1.2.0)
+      net-ssh (>= 2.6.5)
+    net-ssh-multi (1.2.0)
+      net-ssh (>= 2.6.5)
+      net-ssh-gateway (>= 1.2.0)
+    nio4r (1.0.1)
+    nokogiri (1.6.3.1)
+      mini_portile (= 0.6.0)
+    octokit (3.4.0)
+      sawyer (~> 0.5.3)
+    ohai (7.4.0)
+      ffi (~> 1.9)
+      ffi-yajl (~> 1.0)
+      ipaddress
+      mime-types (~> 1.16)
+      mixlib-cli
+      mixlib-config (~> 2.0)
+      mixlib-log
+      mixlib-shellout (~> 1.2)
+      systemu (~> 2.6.4)
+      wmi-lite (~> 1.0)
+    parser (2.2.0.pre.5)
+      ast (>= 1.1, < 3.0)
+      slop (~> 3.4, >= 3.4.5)
+    plist (3.1.0)
+    polyglot (0.3.5)
+    powerpack (0.0.9)
+    pry (0.10.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    rack (1.5.2)
+    rainbow (2.0.0)
+    rake (10.3.2)
+    rest-client (1.6.7)
+      mime-types (>= 1.16)
+    retryable (1.3.6)
+    ridley (4.0.0)
+      addressable
+      buff-config (~> 1.0)
+      buff-extensions (~> 1.0)
+      buff-ignore (~> 1.1)
+      buff-shell_out (~> 0.1)
+      celluloid (~> 0.16.0.pre)
+      celluloid-io (~> 0.16.0.pre)
+      erubis
+      faraday (~> 0.9.0)
+      hashie (>= 2.0.2, < 3.0.0)
+      json (>= 1.7.7)
+      mixlib-authentication (>= 1.3.0)
+      net-http-persistent (>= 2.8)
+      retryable
+      semverse (~> 1.1)
+      varia_model (~> 0.4)
+    rspec (3.1.0)
+      rspec-core (~> 3.1.0)
+      rspec-expectations (~> 3.1.0)
+      rspec-mocks (~> 3.1.0)
+    rspec-core (3.1.7)
+      rspec-support (~> 3.1.0)
+    rspec-expectations (3.1.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.1.0)
+    rspec-mocks (3.1.3)
+      rspec-support (~> 3.1.0)
+    rspec-support (3.1.2)
+    rubocop (0.26.1)
+      astrolabe (~> 1.3)
+      parser (>= 2.2.0.pre.4, < 3.0)
+      powerpack (~> 0.0.6)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.4)
+    ruby-progressbar (1.6.0)
+    rufus-lru (1.0.5)
+    safe_yaml (1.0.4)
+    sawyer (0.5.5)
+      addressable (~> 2.3.5)
+      faraday (~> 0.8, < 0.10)
+    semverse (1.2.1)
+    slop (3.6.0)
+    solve (1.2.1)
+      dep_selector (~> 1.0)
+      semverse (~> 1.1)
+    systemu (2.6.4)
+    test-kitchen (1.2.1)
+      mixlib-shellout (~> 1.2)
+      net-scp (~> 1.1)
+      net-ssh (~> 2.7)
+      safe_yaml (~> 1.0)
+      thor (~> 0.18)
+    thor (0.19.1)
+    timers (4.0.1)
+      hitimes
+    treetop (1.5.3)
+      polyglot (~> 0.3)
+    vagrant-wrapper (1.2.1.1)
+    varia_model (0.4.0)
+      buff-extensions (~> 1.0)
+      hashie (>= 2.0.2, < 3.0.0)
+    wmi-lite (1.0.0)
+    yajl-ruby (1.2.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  berkshelf (~> 3.1)
+  chefspec (~> 4.1)
+  foodcritic (~> 4.0)
+  kitchen-docker (~> 1.5.0)
+  kitchen-sync
+  kitchen-vagrant (~> 0.11)
+  minitest-chef-handler
+  rubocop
+  test-kitchen (~> 1.2)
+  vagrant-wrapper

README.md

@@ -6,14 +6,17 @@ Provides 2 LWRPs to manage system-wide and per-user `ssh_config` and `known_host
 
 ## Usage
 
-When using SSH with Chef deployments, it's crucial to not get any prompts for input. Adding entries to `known_hosts` files and better managing your per-connection configuration can help with this. 
+When using SSH with Chef deployments, it's crucial to not get any prompts for input. Adding entries to `known_hosts` files and better managing your per-connection configuration can help with this.
 
 An important thing to note is that if you create a user during a chef run, be sure to reload OHAI data so that the new user will be in the node data. For instance:
 
     ohai "reload_passwd" do
         plugin "passwd"
     end
 
+The ssh cookbook bypasses this need somewhat by using ohai classes directly to discover your users' ssh paths.  However
+some of your cookbooks may not be as generous.
+
 ## Resources and Providers
 
 ### known_hosts

ROADMAP.md

@@ -0,0 +1,21 @@
+v0.10.0
+===========
+
+* Make everything idempotent
+* Chefspec for everything that can
+* Kitchen for anything we can't chefspec (hopefully that's nothing)
+* use_inline_resources
+* support why_run
+* Merge any outstanding PR's I'm comfortable with
+* Add CONTRIBUTING.md
+
+v0.10.1
+==========
+* add foodcritic support
+
+
+Eventually (PRs are VERY welcome)
+===========
+* Add a authorized_keys resource
+* Get guardfile figured out
+* The order of entries in ssh_config matters.  So we need to support a priority or something to set it with.