You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
closesagntcy#1556
# Description
In some cases checking the header integrity between nodes can't
guarantee the header was not tempered with (e.g. in single-node
deployments. To ensure the the inmutability of the routing header
fields, we need to implement an integrity check also on the client side.
# Changes
- replaced `enable_mls` flag with more complex `MlsSettings` struct (the
field is optional: `None` is equal to `enable_mls = false` and `Some()`
is equal to `enable_mls = true`.
- `MlsSettings` contains the percentage of messages to be validated
(`header_integrity_validation_percent`).
- bench tests added testing the validation of 0%, 50% and 100% of the
messages
- AAD generation is added to MLS message encryption `encrypt_output`
- header integrity check added to `decrypt_message` (only the set
percentage of headers will be checked).
- dynamic port allocation added to servers running parallel in tests.
## Type of Change
- [ ] Bugfix
- [x] New Feature
- [ ] Breaking Change
- [ ] Refactor
- [ ] Documentation
- [ ] Other (please describe)
## Checklist
- [x] I have read the [contributing
guidelines](/agntcy/repo-template/blob/main/CONTRIBUTING.md)
- [x] Existing issues have been referenced (where applicable)
- [x] I have verified this change is not present in other open pull
requests
- [x] Functionality is documented
- [x] All code style checks pass
- [x] New code contribution is covered by automated tests
- [x] All new and existing tests pass
---------
Signed-off-by: Mark Marton <mark.p.marton@gmail.com>
Signed-off-by: Michele Papalini <micpapal@cisco.com>
Signed-off-by: amitami2 <amitami2@cisco.com>
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Mark Marton <30534230+markpmarton@users.noreply.github.com>
Co-authored-by: Michele Papalini <49271675+micpapal@users.noreply.github.com>
Co-authored-by: Amit kumar <amit9116260192@gmail.com>
Co-authored-by: amitami2 <amitami2@cisco.com>
Co-authored-by: Mauro Sardara <msardara@cisco.com>
Co-authored-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
Co-authored-by: János Sarusi-Kis <janossk@cisco.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
0 commit comments