Skip to content

Commit 6d6042f

Browse files
committed
Changes for PHP 8.4.
1 parent c85f142 commit 6d6042f

File tree

5 files changed

+7
-9
lines changed

5 files changed

+7
-9
lines changed

.github/workflows/test_develop_and_master.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
15-
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
15+
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
1616

1717
steps:
1818
- name: Set up PHP
@@ -63,7 +63,7 @@ jobs:
6363
runs-on: ubuntu-latest
6464
strategy:
6565
matrix:
66-
php: ['7.2']
66+
php: ['8.4']
6767

6868
steps:
6969
- name: Set up PHP

.github/workflows/test_other_branches.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
15-
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
15+
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
1616

1717
steps:
1818
- name: Set up PHP
@@ -62,7 +62,7 @@ jobs:
6262
runs-on: ubuntu-latest
6363
strategy:
6464
matrix:
65-
php: ['7.2']
65+
php: ['8.4']
6666

6767
steps:
6868
- name: Set up PHP

.github/workflows/test_pull_request.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
runs-on: ubuntu-latest
99
strategy:
1010
matrix:
11-
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
11+
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
1212

1313
steps:
1414
- name: Set up PHP
@@ -59,7 +59,7 @@ jobs:
5959
runs-on: ubuntu-latest
6060
strategy:
6161
matrix:
62-
php: ['7.2']
62+
php: ['8.4']
6363

6464
steps:
6565
- name: Set up PHP

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ style :
1212
vendor/bin/phpcs --standard=tests/coding_standard.xml --ignore=vendor -s .
1313

1414
phpstan :
15-
vendor/bin/phpstan analyze -c tests/phpstan.neon
15+
vendor/bin/phpstan analyze -c tests/phpstan.neon --memory-limit 1G
1616

1717
phpmd :
1818
vendor/bin/phpmd src/ ansi cleancode,codesize,design,unusedcode,naming

src/LinearAlgebra/NumericMatrix.php

-2
Original file line numberDiff line numberDiff line change
@@ -1283,13 +1283,11 @@ public function multiply($B): NumericMatrix
12831283
$R[$i] = \array_fill(0, $B->n, 0);
12841284
foreach ($Bᵀ as $j => $Bᶜᵒˡ⟦j⟧) {
12851285
foreach ($Aʳᵒʷ⟦i⟧ as $k => $A⟦i⟧⟦k⟧) {
1286-
// @phpstan-ignore-next-line (Remove in PHP 8.0, no longer returns false)
12871286
$R[$i][$j] += $A⟦i⟧⟦k⟧ * $Bᶜᵒˡ⟦j⟧[$k];
12881287
}
12891288
}
12901289
}
12911290

1292-
// @phpstan-ignore-next-line (Due to above false from array_fill)
12931291
return MatrixFactory::createNumeric($R, $this->ε);
12941292
}
12951293

0 commit comments

Comments
 (0)