Implement optimized field reading and decoding for CS2 sendtables #1459
Annotations
11 errors and 1 warning
|
|
|
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
|
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go#L155
[golangci-lint] reported by reviewdog 🐶
G115: integer overflow conversion int -> uint32 (gosec)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go:155:23: G115: integer overflow conversion int -> uint32 (gosec)
reader.size = uint32(len(reader.buf))
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go#L111
[golangci-lint] reported by reviewdog 🐶
G115: integer overflow conversion int -> uint32 (gosec)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go:111:23: G115: integer overflow conversion int -> uint32 (gosec)
reader.size = uint32(len(reader.buf))
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go#L48
[golangci-lint] reported by reviewdog 🐶
G115: integer overflow conversion int -> uint32 (gosec)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go:48:23: G115: integer overflow conversion int -> uint32 (gosec)
reader.size = uint32(len(reader.buf))
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/field_decoder_optimization_test.go#L113
[golangci-lint] reported by reviewdog 🐶
ifElseChain: rewrite if-else to switch statement (gocritic)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/field_decoder_optimization_test.go:113:5: ifElseChain: rewrite if-else to switch statement (gocritic)
if math.IsInf(float64(tc.expected), 0) {
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_optimized.go#L162
[golangci-lint] reported by reviewdog 🐶
ifElseChain: rewrite if-else to switch statement (gocritic)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_optimized.go:162:5: ifElseChain: rewrite if-else to switch statement (gocritic)
if oldLen >= newSize {
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/field_decoder_optimization_test.go#L163
[golangci-lint] reported by reviewdog 🐶
cognitive complexity 34 of func `TestConcurrentSafety` is high (> 30) (gocognit)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/field_decoder_optimization_test.go:163:1: cognitive complexity 34 of func `TestConcurrentSafety` is high (> 30) (gocognit)
func TestConcurrentSafety(t *testing.T) {
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go#L41
[golangci-lint] reported by reviewdog 🐶
File is not properly formatted (gci)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_bench_test.go:41:1: File is not properly formatted (gci)
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_before_after_test.go#L64
[golangci-lint] reported by reviewdog 🐶
File is not properly formatted (gci)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/entity_readfields_before_after_test.go:64:1: File is not properly formatted (gci)
^
|
|
pkg/demoinfocs/sendtables/sendtablescs2/entity.go#L441
[golangci-lint] reported by reviewdog 🐶
File is not properly formatted (gci)
Raw Output:
pkg/demoinfocs/sendtables/sendtablescs2/entity.go:441:1: File is not properly formatted (gci)
^
|
|
|
The logs for this run have expired and are no longer available.
Loading