Skip to content

Commit 6b60fa7

Browse files
committed
Implement PR feedback
1 parent 5d6df1d commit 6b60fa7

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

lib/index.js

+2-8
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,9 @@ color.furthest = function(target, relative, bc) {
3232
};
3333

3434
color.closest_lab = function(target, relative) {
35-
var key = color.lab_palette_map_key(target);
36-
var result = color.map_palette_lab([target], relative, 'closest');
37-
38-
return result[key];
35+
return color.match_palette_lab(target, relative, false);
3936
};
4037

4138
color.furthest_lab = function(target, relative) {
42-
var key = color.lab_palette_map_key(target);
43-
var result = color.map_palette_lab([target], relative, 'furthest');
44-
45-
return result[key];
39+
return color.match_palette_lab(target, relative, true);
4640
};

test/palette.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ describe('palette', function(){
136136
describe('#map_palette_lab()', function (){
137137
it('should map all colors to themselves when possible #1',
138138
function(){
139-
var expected1_1 = {};
139+
var expected1_1 = {};
140140
expected1_1[color_palette.lab_palette_map_key(white_lab)] = white_lab;
141141
expected1_1[color_palette.lab_palette_map_key(black_lab)] = black_lab;
142142
expected1_1[color_palette.lab_palette_map_key(navy_lab)] = navy_lab;
@@ -148,7 +148,7 @@ describe('palette', function(){
148148
});
149149
it('should map all colors to themselves when possible #2',
150150
function(){
151-
var expected1_2 = {};
151+
var expected1_2 = {};
152152
expected1_2[color_palette.lab_palette_map_key(white_a_lab)] = white_a_lab;
153153
expected1_2[color_palette.lab_palette_map_key(black_a_lab)] = black_a_lab;
154154
expected1_2[color_palette.lab_palette_map_key(navy_a_lab)] = navy_a_lab;
@@ -160,7 +160,7 @@ describe('palette', function(){
160160
});
161161
it('should map navy->blue and yellow->gold when navy and yellow are missing',
162162
function(){
163-
var expected2 = {};
163+
var expected2 = {};
164164
expected2[color_palette.lab_palette_map_key(white_lab)] = white_lab;
165165
expected2[color_palette.lab_palette_map_key(black_lab)] = black_lab;
166166
expected2[color_palette.lab_palette_map_key(navy_lab)] = blue_lab;
@@ -172,7 +172,7 @@ describe('palette', function(){
172172
});
173173
it('should map white->black & black,navy,blue->yellow & yellow,gold->blue',
174174
function(){
175-
var expected3 = {};
175+
var expected3 = {};
176176
expected3[color_palette.lab_palette_map_key(white_lab)] = black_lab;
177177
expected3[color_palette.lab_palette_map_key(black_lab)] = yellow_lab;
178178
expected3[color_palette.lab_palette_map_key(navy_lab)] = yellow_lab;

0 commit comments

Comments
 (0)