Skip to content

Presenting CountryCodePickerViewController causes 50% frozen frame rates #833

@hyouuu

Description

@hyouuu

New Issue Checklist

  • [v] Updated PhoneNumberKit to the latest version
  • [v] Phone number formatted correctly on JavaScript version
  • [v] I searched for existing GitHub issues
  • [v] I am aware that this library is not responsible of adding/removing/changing phone number formats and any request should be done at libphonenumber repo

Steps to reproduce

Presenting CountryCodePickerViewController

Expected result

UI loads smoothly without freeze

Actual result

Firebase performance catches that the CountryCodePickerViewController causes frozen frames almost all the time.
Looked at the code and it's probably initializing the country code on the main thread - should have a loading state and load countries in background, and ideally lazily

Environment

SPM 4.0.1 on iOS in various versions

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions