clarified message when no NEW SENEC.System could be found

Author: marq24

custom_components/senec/config_flow.py

@@ -252,11 +252,15 @@ async def _test_connection_senec_online(self, user: str, pwd: str, totp_secret:
                                        storage_path=Path(self.hass.config.config_dir).joinpath(STORAGE_DIR))
 
             if serial_number is None or str(serial_number).lower() == "none":
-                systems = await senec_online.get_all_systems(already_configured_lc_serials)
+                systems, already_in_use_systems = await senec_online.get_all_systems(already_configured_lc_serials)
                 if len(systems) == 0:
                     if senec_online._app_is_authenticated:
-                        self._errors[CONF_SYSTYPE_WEB] = "no_systems_found"
-                        _LOGGER.warning(f"We could not find ANY SENEC.System (is there one available in the SENC.App?")
+                        if len(already_in_use_systems) > 0:
+                            self._errors[CONF_SYSTYPE_WEB] = "no_new_systems_found"
+                            _LOGGER.warning(f"We could not find ANY NEW SENEC.System - already configured: {already_in_use_systems}")
+                        else:
+                            self._errors[CONF_SYSTYPE_WEB] = "no_systems_found"
+                            _LOGGER.warning(f"We could not find ANY SENEC.System (is there one available in the SENC.App?")
                     else:
                         self._errors[CONF_USERNAME] = "login_failed"
                         _LOGGER.warning(f"Could not connect to mein-senec.de with '{user}', check credentials")

custom_components/senec/pysenec_ha/__init__.py

@@ -3465,6 +3465,7 @@ async def get_all_systems(self, already_configured_lc_serials: list = None):
             await self.app_authenticate(check_for_existing_tokens = True, is_integration_setup_phase = True)
 
         systems = {}
+        already_in_use_systems = {}
         if self._app_is_authenticated:
             app_data = await self._app_do_get_request(self.APP_SYSTEM_LIST)
             if app_data is not None and isinstance(app_data, Iterable):
@@ -3478,10 +3479,17 @@ async def get_all_systems(self, already_configured_lc_serials: list = None):
                                 "addr": f'{a_entry.get("street", "STREET")} {a_entry.get("houseNumber", "HOUSENUMBER")}, {a_entry.get("postalCode", "POSTALCODE")} {a_entry.get("city", "CITY")}',
                                 "serial": serial
                             }
+                        else:
+                            already_in_use_systems[serial] = {
+                                "name": a_entry.get("product", {}).get("name", "UNKNOWN-NAME"),
+                                "case": a_entry.get("caseNumber", "CASENUMBER"),
+                                "serial": serial
+                            }
+                            _LOGGER.info(f"get_all_systems(): Skipping already configured system with serial {serial} - since it is already in the 'already_configured_lc_serials' list {already_configured_lc_serials}")
         else:
             _LOGGER.debug(f"get_all_systems(): self._app_is_authenticated is {self._app_is_authenticated}")
 
-        return systems
+        return systems, already_in_use_systems
 
     # by default, we update as fast as possible
     _UPDATE_INTERVAL = NO_LIMIT

custom_components/senec/translations/de.json

@@ -43,14 +43,16 @@
       "reauth_successful": "Re-Autorisierung abgeschlossen",
       "no_filesystem_access": "Diese Integration benötigt Zugriff auf das lokale Dateisystem Deiner HomeAssistant Installation, um einen Schlüssel für Deinen SENEC Account speichern zu können.\n\nHierzu wird im in dem Ordner '.storage/' einen Unterordner anlegen. Dies ist jedoch derzeit nicht möglich. Ein interner Test ist fehlgeschlagen. Details hierzu findest Du im LOG Deiner Home Assistant Instanz.\n\nBitte stelle sicher, dass Du die Home Assistant Installation mit dem richtigen Benutzer ausführst, der Schreibzugriff auf das lokale Dateisystem hat.\n\nWenn Du Home Assistant in einem Docker-Container ausführst, stelle sicher, dass Du den Container mit dem richtigen Benutzer ausführst und dass der Container Zugriff auf das lokale Dateisystem hat.\n\nBitte prüfe Deine installation und starte die Einrichtung dieser Integration neu, sobald der Zugriff auf das lokale Dateisystem möglich ist.",
       "invalid_totp_secret": "Das OTP-auth-Secret konnte nicht interpretiert werden",
-      "no_systems_found": "Es konnten keine SENEC.Systeme ermittelt werden - hast Du in der Senec.App ein Speicher System?"
+      "no_systems_found": "Es konnten keine SENEC.Systeme ermittelt werden - hast Du in der Senec.App ein Speicher System?",
+      "no_new_systems_found": "Es konnten keine weiteres SENEC.Systeme ermittelt werden - es sind bereits all Deine SENEC.Systeme eingerichtet"
     },
     "error": {
       "login_failed": "Login fehlgeschlagen - bitte Benutzername und/oder Passwort prüfen",
       "cannot_connect": "Keine Verbindung möglich",
       "unknown": "Unbekannter Fehler",
       "invalid_totp_secret": "OTP-auth-Secret ist ungültig",
-      "no_systems_found": "Es konnten keine SENEC.Systeme ermittelt werden - hast Du in der Senec.App ein Speicher System?"
+      "no_systems_found": "Es konnten keine SENEC.Systeme ermittelt werden - hast Du in der Senec.App ein Speicher System?",
+      "no_new_systems_found": "Es konnten keine weiteres SENEC.Systeme ermittelt werden - es sind bereits all Deine SENEC.Systeme eingerichtet"
     },
     "step": {
       "user": {

custom_components/senec/translations/en.json

@@ -30,14 +30,16 @@
       "reauth_successful": "Re-Authorization was completed",
       "no_filesystem_access": "This integration requires access to the local file system of your HomeAssistant installation to store a key for your Senec account.\n\nTo do this, a subfolder will be created in the '.storage/' folder. However, this is currently not possible. An internal test failed. You can find details in the log of your Home Assistant instance.\n\nPlease ensure that you are running the Home Assistant installation with the correct user who has write access to the local file system.\n\nIf you are running Home Assistant in a Docker container, ensure that you are running the container with the correct user and that the container has access to the local file system.\n\nPlease check your installation and restart the setup of this integration once access to the local file system is possible.",
       "invalid_totp_secret": "The provided OTP-auth-Secret could not be interpreted",
-      "no_systems_found": "No SENEC.System could be detected  - Do you have a system in the Senec.App?"
+      "no_systems_found": "No SENEC.System could be detected - Do you have a system in the Senec.App?",
+      "no_new_systems_found": "No new SENEC.System could be detected - all your SENEC.Systems are already configured!"
     },
     "error": {
       "login_failed": "Login failed - please check username and/or password",
       "cannot_connect": "Failed to connect",
       "unknown": "Unknown error",
       "invalid_totp_secret": "OTP-auth-Secret invalid",
-      "no_systems_found": "No SENEC.System could be detected  - Do you have a system in the Senec.App?"
+      "no_systems_found": "No SENEC.System could be detected - Do you have a system in the Senec.App?",
+      "no_new_systems_found": "No new SENEC.System could be detected - all your SENEC.Systems are already configured!"
     },
     "step": {
       "user": {