Skip to content

Commit 3a98b06

Browse files
committed
pw form fields
1 parent db80188 commit 3a98b06

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

components/http_server/http_server.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3263,15 +3263,17 @@ static esp_err_t vpn_get_handler(httpd_req_t *req)
32633263

32643264
if (httpd_query_key_value(buf, "vpn_privkey", param, sizeof(param)) == ESP_OK) {
32653265
preprocess_string(param);
3266-
nvs_set_str(nvs, "vpn_privkey", param);
3266+
if (param[0] != '\0')
3267+
nvs_set_str(nvs, "vpn_privkey", param);
32673268
}
32683269
if (httpd_query_key_value(buf, "vpn_pubkey", param, sizeof(param)) == ESP_OK) {
32693270
preprocess_string(param);
32703271
nvs_set_str(nvs, "vpn_pubkey", param);
32713272
}
32723273
if (httpd_query_key_value(buf, "vpn_psk", param, sizeof(param)) == ESP_OK) {
32733274
preprocess_string(param);
3274-
nvs_set_str(nvs, "vpn_psk", param);
3275+
if (param[0] != '\0')
3276+
nvs_set_str(nvs, "vpn_psk", param);
32753277
}
32763278
if (httpd_query_key_value(buf, "vpn_endpoint", param, sizeof(param)) == ESP_OK) {
32773279
preprocess_string(param);
@@ -3381,8 +3383,8 @@ static esp_err_t vpn_get_handler(httpd_req_t *req)
33813383
httpd_resp_send_chunk(req, row, HTTPD_RESP_USE_STRLEN);
33823384

33833385
snprintf(row, VPN_BUF_SIZE,
3384-
"<tr><td>Private Key</td><td><input type='password' name='vpn_privkey' value='%s' placeholder='Base64 private key'/></td></tr>",
3385-
vpn_private_key ? vpn_private_key : "");
3386+
"<tr><td>Private Key</td><td><input type='password' name='vpn_privkey' placeholder='%s'/></td></tr>",
3387+
(vpn_private_key && vpn_private_key[0]) ? "unchanged" : "Base64 private key");
33863388
httpd_resp_send_chunk(req, row, HTTPD_RESP_USE_STRLEN);
33873389

33883390
snprintf(row, VPN_BUF_SIZE,
@@ -3391,8 +3393,8 @@ static esp_err_t vpn_get_handler(httpd_req_t *req)
33913393
httpd_resp_send_chunk(req, row, HTTPD_RESP_USE_STRLEN);
33923394

33933395
snprintf(row, VPN_BUF_SIZE,
3394-
"<tr><td>Preshared Key</td><td><input type='password' name='vpn_psk' value='%s' placeholder='Optional'/></td></tr>",
3395-
vpn_preshared_key ? vpn_preshared_key : "");
3396+
"<tr><td>Preshared Key</td><td><input type='password' name='vpn_psk' placeholder='%s'/></td></tr>",
3397+
(vpn_preshared_key && vpn_preshared_key[0]) ? "unchanged" : "Optional");
33963398
httpd_resp_send_chunk(req, row, HTTPD_RESP_USE_STRLEN);
33973399

33983400
snprintf(row, VPN_BUF_SIZE,

components/http_server/pages/page_config.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ setTimeout(\"location.href = '/'\", 10000);\
7272
<form action='' method='GET'>\
7373
<table>\
7474
<tr><td>SSID</td><td><input type='text' name='ap_ssid' value='%s' placeholder='Network name'/></td></tr>\
75-
<tr><td>Password</td><td><input type='text' id='ap_pw' name='ap_password' placeholder='unchanged' oninput=\"document.getElementById('ap_op').checked=false;\"/></td></tr>\
75+
<tr><td>Password</td><td><input type='password' id='ap_pw' name='ap_password' placeholder='unchanged' oninput=\"document.getElementById('ap_op').checked=false;\"/></td></tr>\
7676
<tr><td>AP IP Address</td><td><input type='text' name='ap_ip_addr' value='%s' placeholder='192.168.4.1'/></td></tr>\
7777
<tr><td>DNS Server</td><td><input type='text' name='ap_dns' value='%s' placeholder='empty = use upstream DNS'/></td></tr>\
7878
<tr><td>MAC Address</td><td><input type='text' name='ap_mac' value='%s' placeholder='AA:BB:CC:DD:EE:FF'/></td></tr>\
@@ -108,7 +108,7 @@ setTimeout(\"location.href = '/'\", 10000);\
108108
<form action='' method='GET'>\
109109
<table>\
110110
<tr><td>SSID</td><td><input type='text' name='ssid' value='%s' placeholder='Uplink network'/></td></tr>\
111-
<tr><td>Password</td><td><input type='text' name='password' placeholder='unchanged'/></td></tr>\
111+
<tr><td>Password</td><td><input type='password' name='password' placeholder='unchanged'/></td></tr>\
112112
" CONFIG_CHUNK_STA_BAND_ROW "\
113113
<tr><td colspan='2' style='padding-top: 1rem; color: #888; font-size: 0.85rem;'>WPA2 Enterprise (optional)</td></tr>\
114114
<tr><td>Username</td><td><input type='text' name='ent_username' value='%s' placeholder='Enterprise username'/></td></tr>\

0 commit comments

Comments
 (0)