add health and readiness probes

Author: martinabeleda

docker-compose.test.yml

@@ -70,7 +70,7 @@ services:
       migration:
         condition: service_completed_successfully
     healthcheck:
-      test: ["CMD-SHELL", "curl -f http://localhost:8080/docs || exit 1"]
+      test: ["CMD-SHELL", "curl -f http://localhost:8080/ready || exit 1"]
       interval: 5s
       timeout: 10s
       retries: 10

docker-compose.yml

@@ -63,7 +63,7 @@ services:
       migration:
         condition: service_completed_successfully
     healthcheck:
-      test: ["CMD-SHELL", "curl -f http://localhost:8080/docs || exit 1"]
+      test: ["CMD-SHELL", "curl -f http://localhost:8080/ready || exit 1"]
       interval: 10s
       timeout: 10s
       retries: 5

strava/main.py

@@ -1,8 +1,11 @@
 from contextlib import asynccontextmanager
 
-from fastapi import APIRouter, FastAPI
+from fastapi import APIRouter, Depends, FastAPI
+from sqlalchemy import text
+from sqlalchemy.orm import Session
 
 from strava.config import settings
+from strava.db.depends import get_db
 from strava.db.session import engine
 from strava.observability import configure_observability
 from strava.routes import routes
@@ -21,3 +24,14 @@ async def lifespan(_: FastAPI):
 app = FastAPI(title=settings.PROJECT_NAME, lifespan=lifespan)
 configure_observability(app, settings, engine)
 app.include_router(v1_router, prefix=settings.API_V1_STR)
+
+
+@app.get("/health")
+async def health():
+    return {"status": "ok"}
+
+
+@app.get("/ready")
+def ready(db: Session = Depends(get_db)):
+    db.execute(text("SELECT 1"))
+    return {"status": "ok"}