Skip to content

Commit 5d605f7

Browse files
committed
fix #810
1 parent 1efefad commit 5d605f7

3 files changed

Lines changed: 19 additions & 15 deletions

File tree

src/librssguard/gui/tabwidget.cpp

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ void TabWidget::showDownloadManager() {
8181
}
8282

8383
void TabWidget::checkTabBarVisibility() {
84-
const bool should_be_visible = count() > 1 ||
85-
!qApp->settings()->value(GROUP(GUI), SETTING(GUI::HideTabBarIfOnlyOneTab)).toBool();
84+
const bool should_be_visible =
85+
count() > 1 || !qApp->settings()->value(GROUP(GUI), SETTING(GUI::HideTabBarIfOnlyOneTab)).toBool();
8686

8787
if (should_be_visible) {
8888
setCornerWidget(m_btnMainMenu, Qt::Corner::TopLeftCorner);
@@ -123,8 +123,14 @@ void TabWidget::createConnections() {
123123
connect(tabBar(), &TabBar::tabCloseRequested, this, &TabWidget::closeTab);
124124
connect(tabBar(), &TabBar::tabMoved, this, &TabWidget::fixContentsAfterMove);
125125

126-
connect(feedMessageViewer()->messagesView(), &MessagesView::openMessagesInNewspaperView, this, &TabWidget::addNewspaperView);
127-
connect(feedMessageViewer()->feedsView(), &FeedsView::openMessagesInNewspaperView, this, &TabWidget::addNewspaperView);
126+
connect(feedMessageViewer()->messagesView(),
127+
&MessagesView::openMessagesInNewspaperView,
128+
this,
129+
&TabWidget::addNewspaperView);
130+
connect(feedMessageViewer()->feedsView(),
131+
&FeedsView::openMessagesInNewspaperView,
132+
this,
133+
&TabWidget::addNewspaperView);
128134
}
129135

130136
void TabWidget::initializeTabs() {
@@ -195,14 +201,12 @@ void TabWidget::closeCurrentTab() {
195201

196202
int TabWidget::addNewspaperView(RootItem* root, const QList<Message>& messages) {
197203
WebBrowser* browser = new WebBrowser(nullptr, this);
204+
198205
int index = addTab(browser,
199206
qApp->icons()->fromTheme(QSL("format-justify-fill")),
200207
tr("Newspaper view"),
201208
TabBar::TabType::Closable);
202209

203-
// NOTE: Do not bring "newspaper" tabs to front anymore.
204-
//setCurrentIndex(index);
205-
206210
QTimer::singleShot(300, browser, [browser, root, messages]() {
207211
browser->loadMessages(messages, root);
208212
});
@@ -232,14 +236,16 @@ int TabWidget::addBrowser(bool move_after_current, bool make_active, WebBrowser*
232236

233237
if (move_after_current) {
234238
// Insert web browser after current tab.
235-
final_index = insertTab(currentIndex() + 1, browser, qApp->icons()->fromTheme(QSL("text-html")),
236-
browser_tab_name, TabBar::TabType::Closable);
239+
final_index = insertTab(currentIndex() + 1,
240+
browser,
241+
qApp->icons()->fromTheme(QSL("text-html")),
242+
browser_tab_name,
243+
TabBar::TabType::Closable);
237244
}
238245
else {
239246
// Add new browser as the last tab.
240-
final_index = addTab(browser, qApp->icons()->fromTheme(QSL("text-html")),
241-
browser_tab_name,
242-
TabBar::TabType::Closable);
247+
final_index =
248+
addTab(browser, qApp->icons()->fromTheme(QSL("text-html")), browser_tab_name, TabBar::TabType::Closable);
243249
}
244250

245251
// Make connections.

src/librssguard/gui/webbrowser.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,6 @@ void WebBrowser::loadMessages(const QList<Message>& messages, RootItem* root) {
152152
if (!m_root.isNull()) {
153153
m_searchWidget->hide();
154154
m_webView->loadMessages(messages, root);
155-
156-
show();
157155
}
158156
}
159157

src/librssguard/miscellaneous/textfactory.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ int TextFactory::stringWidth(const QString& string, const QFontMetrics& metrics)
6767
bool TextFactory::couldBeHtml(const QString& string) {
6868
const QString sstring = string.simplified();
6969

70-
return sstring.startsWith(QL1S("<!")) || Qt::mightBeRichText(sstring);
70+
return sstring.startsWith(QL1S("<!")) || sstring.startsWith(QL1S("<figure")) || Qt::mightBeRichText(sstring);
7171
}
7272

7373
QDateTime TextFactory::parseDateTime(const QString& date_time) {

0 commit comments

Comments
 (0)