default light/dark skin/icon alternatives, enable survey

Author: martinrotter

resources/text/CHANGELOG

@@ -2,8 +2,14 @@
 -----
 Released on: 2026-03-03
 
+PLEASE, read the text below!
+
 This release contains some nice fixes and little enhancements from previous version. Thanks for your patience.
 
+For users with dark desktop themes -> make sure to switch to `minimal-dark` skin in your RSS Guard settings. This skin is specifically tailored for users who use dark desktop themes.
+
+As for the discussion around now-removed `QtWebEngine` and web browsing capabilities. There is argument that RSS Guard now cannot display "full" articles. Wrong. There is a setting in `Experimental` section of feed details dialog which can enable fetching full articles, even optionally in plain text format. Also, see below as this feature was even enhanced in this latest app version. I do not plan re-introducing web browsing capabilities because there are technical and (mainly) security implications which I want to avoid at all costs. RSS Guard provides ways to read full articles and if anyone wants to go to source website, just click the link and use the website in dedicated web browser which provides you with right tools to elevate your security in the online environment.
+
 Added:
 * All text is selected when focusing search textbox. (#2061)
 * Filtering of feed list now takes much more feed data into account like URL, description, etc. (#2059)
@@ -12,7 +18,7 @@ Added:
 * You now can drag URLs from article HTML preview to outside of RSS Guard. (#2032)
 
 Fixed:
-* Quick note for #2044. If you use dark desktop environment scheme, then use `minimal-dark` skin, please. This one is specifically tailored for dark environments.
+* Quick note for #2044. If you use dark desktop environment scheme, then again, use `minimal-dark` skin, please. This one is specifically tailored for dark environments. I added a tweak to make `minimal-dark` (and `Breeze Dark`) default skin for users with dark desktop themes. This only applies when RSS Guard is started with clean config and also is supported only on some platforms.
 * Article automatic limit/control and article custom IDs are now also migrated from RSS Guard 4.x. (#2042)
 * All menu items can be now properly assigned to shortcuts and added to toolbars. (#2040)
 * Fix the bug in loading article pictures when going offline/online and vice versa. (#2033)

src/librssguard/definitions/definitions.h

@@ -227,17 +227,21 @@
 
 #define APP_SKIN_USER_FOLDER   "skins"
 #define APP_SKIN_DEFAULT       "minimal-light"
+#define APP_SKIN_DEFAULT_DARK  "minimal-dark"
 #define APP_SKIN_METADATA_FILE "metadata.xml"
 
 #if defined(FORCE_BUNDLE_ICONS)
 // Forcibly bundle icons.
-#define APP_ICON_THEME_DEFAULT "Breeze"
+#define APP_ICON_THEME_DEFAULT      "Breeze"
+#define APP_ICON_THEME_DARK_DEFAULT "Breeze Dark"
 #elif defined(Q_OS_UNIX) && !defined(Q_OS_MACOS)
 // Do not force default icon theme on Linux.
-#define APP_ICON_THEME_DEFAULT ""
+#define APP_ICON_THEME_DEFAULT      ""
+#define APP_ICON_THEME_DARK_DEFAULT ""
 #else
 // Use some default theme otherwise.
-#define APP_ICON_THEME_DEFAULT "Breeze"
+#define APP_ICON_THEME_DEFAULT      "Breeze"
+#define APP_ICON_THEME_DARK_DEFAULT "Breeze Dark"
 #endif
 
 #define APP_LOCAL_ICON_THEME_FOLDER "icons"

src/librssguard/miscellaneous/application.cpp

@@ -293,11 +293,9 @@ void Application::loadDynamicShortcuts() {
 }
 
 void Application::offerPolls() const {
-  /*
   if (isFirstRunCurrentVersion()) {
-    qApp->web()->openUrlInExternalBrowser(QSL("https://forms.gle/3CZm95W6vrBLfi5K9"));
+    qApp->web()->openUrlInExternalBrowser(QSL("https://forms.gle/1dCgqi2p1TEGn73d8"));
   }
-  */
 }
 
 void Application::offerChanges() const {

src/librssguard/miscellaneous/iconfactory.cpp

@@ -177,12 +177,16 @@ void IconFactory::setCurrentIconTheme(const QString& theme_name) {
 }
 
 QString IconFactory::currentIconTheme() const {
-  return qApp->settings()->value(GROUP(GUI), SETTING(GUI::IconTheme)).toString();
+  return qApp->settings()
+    ->value(GROUP(GUI),
+            GUI::IconTheme,
+            SkinFactory::isOsDarkModeEnabled() ? APP_ICON_THEME_DARK_DEFAULT : APP_ICON_THEME_DEFAULT)
+    .toString();
 }
 
 void IconFactory::loadCurrentIconTheme() {
   const QStringList installed_themes = installedIconThemes();
-  const QString theme_name_from_settings = qApp->settings()->value(GROUP(GUI), SETTING(GUI::IconTheme)).toString();
+  const QString theme_name_from_settings = currentIconTheme();
 
   if (QIcon::themeName() == theme_name_from_settings) {
     qDebugNN << LOGSEC_GUI << "Icon theme" << QUOTE_W_SPACE(theme_name_from_settings) << "already loaded.";

src/librssguard/miscellaneous/settings.cpp

@@ -386,10 +386,8 @@ DKEY GUI::DefaultSortOrderFeeds = "default_sort_order_feeds";
 DVALUE(Qt::SortOrder) GUI::DefaultSortOrderFeedsDef = Qt::AscendingOrder;
 
 DKEY GUI::IconTheme = "icon_theme_name";
-DVALUE(char*) GUI::IconThemeDef = APP_ICON_THEME_DEFAULT;
 
 DKEY GUI::Skin = "skin";
-DVALUE(char*) GUI::SkinDef = APP_SKIN_DEFAULT;
 
 DKEY GUI::Style = "style";
 DVALUE(char*) GUI::StyleDef = APP_STYLE_DEFAULT;

src/librssguard/miscellaneous/settings.h

@@ -403,10 +403,8 @@ namespace GUI {
   VALUE(Qt::SortOrder) DefaultSortOrderFeedsDef;
 
   KEY IconTheme;
-  VALUE(char*) IconThemeDef;
 
   KEY Skin;
-  VALUE(char*) SkinDef;
 
   KEY Style;
   VALUE(char*) StyleDef;

src/librssguard/miscellaneous/skinfactory.cpp

@@ -213,8 +213,32 @@ QString SkinFactory::customSkinBaseFolder() const {
   return qApp->userDataFolder() + QDir::separator() + APP_SKIN_USER_FOLDER;
 }
 
+#if defined(Q_OS_WIN)
+bool isWindowsDarkMode() {
+  QSettings settings(QSL("HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize"),
+                     QSettings::Format::NativeFormat);
+  QVariant value = settings.value(QSL("AppsUseLightTheme"));
+
+  return !value.isValid() ? false : (value.toInt() == 0);
+}
+#endif
+
+bool SkinFactory::isOsDarkModeEnabled() {
+#if defined(Q_OS_WIN)
+  return isWindowsDarkMode();
+#elif QT_VERSION >= 0x060500 // Qt >= 6.5.0
+  return qApp->styleHints()->colorScheme() == Qt::ColorScheme::Dark;
+#else
+  return false;
+#endif
+}
+
 QString SkinFactory::selectedSkinName() const {
-  return qApp->settings()->value(GROUP(GUI), SETTING(GUI::Skin)).toString();
+  bool is_dark = isOsDarkModeEnabled();
+
+  return qApp->settings()
+    ->value(GROUP(GUI), GUI::Skin, is_dark ? QSL(APP_SKIN_DEFAULT_DARK) : QSL(APP_SKIN_DEFAULT))
+    .toString();
 }
 
 QString SkinFactory::prepareHtml(const QString& inner_html) {

src/librssguard/miscellaneous/skinfactory.h

@@ -97,6 +97,8 @@ class RSSGUARD_DLLSPEC SkinFactory : public QObject {
 
     bool isStyleGoodForAlternativeStylePalette(const QString& style_name) const;
 
+    static bool isOsDarkModeEnabled();
+
     // Returns the name of the skin, that should be activated
     // after application restart.
     QString selectedSkinName() const;