fix: windows release CI workflow

Author: martona

.github/workflows/_release.yml

@@ -289,7 +289,11 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: werdumps-${{ matrix.arch }}
-          path: ${{ env.WER_DUMP_DIR }}
+          # Spelled out rather than ${{ env.WER_DUMP_DIR }}: that var is exported by
+          # the enable-WER step, which is SKIPPED when an earlier step fails -- and
+          # this step runs precisely on failure. An empty path is a hard error that
+          # masks the real one.
+          path: ${{ runner.temp }}\werdumps
           if-no-files-found: ignore
 
       - name: Uninstall MSIX

scripts/package_windows_msix.ps1

@@ -227,7 +227,19 @@ $manifest = (Get-Content -Raw $manifestTemplate).
     Replace('@PUBLISHER_DISPLAY_NAME@', $PublisherDisplayName).
     Replace('@VERSION@', $Version).
     Replace('@ARCH@', $msixArch)
-Set-Content -Path (Join-Path $layout 'AppxManifest.xml') -Value $manifest -Encoding UTF8
+$manifestPath = Join-Path $layout 'AppxManifest.xml'
+Set-Content -Path $manifestPath -Value $manifest -Encoding UTF8
+# makepri reports a malformed manifest as PRI191 buried mid-scroll in a UTF-16-mangled
+# usage dump (first hit: '--' inside an XML comment, which the XML spec forbids).
+# Validate here so the failure is one readable line instead.
+try {
+    $probe = New-Object System.Xml.XmlDocument
+    $probe.LoadXml((Get-Content -Raw $manifestPath))
+}
+catch {
+    $reason = if ($_.Exception.InnerException) { $_.Exception.InnerException.Message } else { $_.Exception.Message }
+    throw "Substituted AppxManifest.xml is not well-formed XML: $reason"
+}
 
 # --- index resources (resources.pri) -----------------------------------------
 # Without this, Windows ignores the scale/targetsize/unplated qualifier files and the
@@ -236,7 +248,7 @@ New-Item -ItemType Directory -Force -Path $OutDir | Out-Null
 $priConfig = Join-Path $OutDir 'priconfig.xml'
 & $makepri createconfig /cf $priConfig /dq en-US /o
 if ($LASTEXITCODE -ne 0) { throw "makepri createconfig failed ($LASTEXITCODE)." }
-& $makepri new /pr $layout /cf $priConfig /mn (Join-Path $layout 'AppxManifest.xml') /of (Join-Path $layout 'resources.pri') /o
+& $makepri new /pr $layout /cf $priConfig /mn $manifestPath /of (Join-Path $layout 'resources.pri') /o
 if ($LASTEXITCODE -ne 0) { throw "makepri new failed ($LASTEXITCODE)." }
 
 # --- pack --------------------------------------------------------------------

src/platform/win32/msix/AppxManifest.xml.in

@@ -65,12 +65,12 @@
     <Logo>Images\StoreLogo.png</Logo>
     <!-- File writes land in the REAL file system, not the per-package overlay.
          Needed by the Explorer SendTo integration: the Clipp.lnk must land in the
-         real shell:SendTo folder (under %APPDATA%) or Explorer never shows it -- the
+         real shell:SendTo folder (under %APPDATA%) or Explorer never shows it — the
          file-side twin of the copy-on-write registry trap above. Pairs with the
          unvirtualizedResources capability below. Consequences: (a) app state files
          (%LOCALAPPDATA%\Clipp: register snapshot, logs, crashdumps) now land in the
          real location, shared with an unpackaged install and left behind on
-         uninstall -- settings/key/host id are REGISTRY and stay virtualized, and a
+         uninstall — settings/key/host id are REGISTRY and stay virtualized, and a
          once-virtualized register snapshot is re-synced from the mesh, so no file
          migration is needed on upgrade; (b) desktop6 is ignorable, so pre-2004
          Windows keeps virtualization on and SendTo registration is silently inert