TokenRefreshError: session deleted by another tab

[not-my-profile]

I'm using @atcute/oauth-browser-client in a Vite app. It works great except that there's a small issue with Vite's HMR.

I have a module that's calling getSession(did, { allowStale: true }) on page load (with a did I've stored in the localStorage after a prior login).
I can reload the page and it works. However when I trigger Vite's HMR by changing the code and then reload the page getSession fails with:

 TokenRefreshError: session deleted by another tab
    TokenRefreshError errors.ts:21
    refreshToken sessions.ts:115
    run sessions.ts:63
    getSession sessions.ts:72

In case it matters: my configureOAuth call is in a different module than the getSession and not rerun by the HMR.

[mary-ext]

I don't think it's due to Vite HMR in particular but just really unfortunate timing between Vite HMR managing to call a session invalidation somewhere and a page reload action abruptly interrupting the token refresh process

I'm not sure yet, it's certainly the one thing I've encountered the most though

[not-my-profile]

I can wait a minute between the HMR and the manual page reload after and getSession will throw this TokenRefreshError, so my assumption would be that the HMR alone is already messing the session state up. If you tell me where I can add some console.logs in @atcute/oauth-browser-client so we can understand more what's happening.

[not-my-profile]

Oops. I'm sorry the fault was entirely in my own code! In another file I had:

  async signIn(session: OAuthSession): Promise<Result<User>> {
    if (this.session) {
      await this.signOut();
    }

(I finally noticed that this also happened when retriggering the code without any HMR or page reload)

[not-my-profile]

I was led astray by the "by another tab" in the error message. Opened #70 to drop it.