Skip to content

Commit 7ae90ea

Browse files
committed
chore: simplify sed usage on mac
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
1 parent 05e17bb commit 7ae90ea

1 file changed

Lines changed: 13 additions & 18 deletions

File tree

kind-gpu-sim.sh

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@ else
1919
PID_CMD="pidof"
2020
fi
2121

22+
# Allows building bundles in Mac replacing BSD 'sed' command by GNU-compatible 'gsed'
23+
if command -v which gsed 2>/dev/null; then
24+
SED=sed
25+
else
26+
SED=gsed
27+
fi
28+
2229
for arg in "$@"; do
2330
case "$arg" in
2431
--registry-port=*)
@@ -142,15 +149,9 @@ function build_and_push_images() {
142149

143150
if [ "$CONTAINER_RUNTIME" = "podman" ]; then
144151
echo "Patching NVIDIA Dockerfile for Podman compatibility..."
145-
if [ "$IS_MACOS" = true ]; then
146-
sed -i '' 's|^FROM redhat/ubi9-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
147-
sed -i '' 's|^FROM public.ecr.aws/ubi9/ubi-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
148-
sed -i '' 's|^FROM registry.access.redhat.com/ubi9/ubi9-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
149-
else
150-
sed -i 's|^FROM redhat/ubi9-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
151-
sed -i 's|^FROM public.ecr.aws/ubi9/ubi-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
152-
sed -i 's|^FROM registry.access.redhat.com/ubi9/ubi9-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
153-
fi
152+
${SED} -i 's|^FROM redhat/ubi9-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
153+
${SED} -i 's|^FROM public.ecr.aws/ubi9/ubi-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
154+
${SED} -i 's|^FROM registry.access.redhat.com/ubi9/ubi9-minimal|FROM registry.access.redhat.com/ubi9/ubi-minimal|' deployments/container/Dockerfile
154155
grep FROM deployments/container/Dockerfile
155156
fi
156157

@@ -175,15 +176,9 @@ function build_and_push_images() {
175176
cd k8s-device-plugin-rocm
176177

177178
echo " Patching ROCm Dockerfile for public registry compatibility..."
178-
if [ "$IS_MACOS" = true ]; then
179-
sed -i '' 's|FROM alpine:3.21.3|FROM public.ecr.aws/docker/library/alpine:3.21.3|' Dockerfile
180-
sed -i '' 's|FROM docker.io/golang:1.23.6-alpine3.21|FROM public.ecr.aws/docker/library/golang:1.23.6-alpine3.21|' Dockerfile
181-
sed -i '' 's|FROM golang:1.23.6-alpine3.21|FROM public.ecr.aws/docker/library/golang:1.23.6-alpine3.21|' Dockerfile
182-
else
183-
sed -i 's|FROM alpine:3.21.3|FROM public.ecr.aws/docker/library/alpine:3.21.3|' Dockerfile
184-
sed -i 's|FROM docker.io/golang:1.23.6-alpine3.21|FROM public.ecr.aws/docker/library/golang:1.23.6-alpine3.21|' Dockerfile
185-
sed -i 's|FROM golang:1.23.6-alpine3.21|FROM public.ecr.aws/docker/library/golang:1.23.6-alpine3.21|' Dockerfile
186-
fi
179+
${SED} -i 's|FROM alpine:3.21.3|FROM public.ecr.aws/docker/library/alpine:3.21.3|' Dockerfile
180+
${SED} -i 's|FROM docker.io/golang:1.23.6-alpine3.21|FROM public.ecr.aws/docker/library/golang:1.23.6-alpine3.21|' Dockerfile
181+
${SED} -i 's|FROM golang:1.23.6-alpine3.21|FROM public.ecr.aws/docker/library/golang:1.23.6-alpine3.21|' Dockerfile
187182

188183
cr build -t localhost:${REGISTRY_PORT}/amdgpu-dp:dev -f Dockerfile .
189184

0 commit comments

Comments
 (0)