try fix args for running smoke

Author: VladMstv

apps/ehr/package.json

@@ -39,8 +39,8 @@
     "component-tests": "vitest --config ./vitest.config.component-tests.ts",
     "test": "npm run unit-tests -- --watch=false && npm run component-tests -- --watch=false",
     "e2e:login": "npm run e2e-skeleton ./tests/e2e/login",
-    "e2e:specs": "npm run e2e-skeleton ./tests/e2e/specs",
-    "e2e:specs:ui": "npm run e2e-skeleton ./tests/e2e/specs -- --ui",
+    "e2e:specs": "npm run e2e-skeleton -- ./tests/e2e/specs $PLAYWRIGHT_EXTRA_ARGS",
+    "e2e:specs:ui": "npm run e2e-skeleton -- ./tests/e2e/specs --ui $PLAYWRIGHT_EXTRA_ARGS",
     "e2e:manual-login": "node ./auth.setup.js",
     "e2e-skeleton": "env-cmd -f ./env/tests.${ENV}.json playwright test",
     "setup-test-deps": "node setup-test-deps.js",

apps/intake/package.json

@@ -32,8 +32,8 @@
     "lint": "NODE_OPTIONS='--max-old-space-size=8192' eslint --ext .ts,.tsx,.js,.jsx --report-unused-disable-directives --max-warnings 0 .",
     "lint:fix": "NODE_OPTIONS='--max-old-space-size=8192' eslint --ext .ts,.tsx,.js,.jsx --report-unused-disable-directives --max-warnings 0 --fix .",
     "e2e:login": "npm run e2e-skeleton ./tests/login/",
-    "e2e:specs": "npm run e2e-skeleton ./tests/specs/",
-    "e2e:specs:ui": "npm run e2e-skeleton ./tests/specs/ -- --ui",
+    "e2e:specs": "npm run e2e-skeleton -- ./tests/specs/ $PLAYWRIGHT_EXTRA_ARGS",
+    "e2e:specs:ui": "npm run e2e-skeleton -- ./tests/specs/ --ui $PLAYWRIGHT_EXTRA_ARGS",
     "e2e:specs:in-person": "npm run e2e-skeleton ./tests/specs/in-person/ -- --ui",
     "e2e:specs:telemed": "npm run e2e-skeleton ./tests/specs/telemed/ -- --ui",
     "e2e:manual-login": "node ./auth.setup.js",

package.json

@@ -57,6 +57,7 @@
     "ehr:e2e:local": "tsx scripts/run-e2e.ts --app=ehr",
     "ehr:e2e:local:integration": "INTEGRATION_TEST=true tsx scripts/run-e2e.ts --app=ehr",
     "ehr:e2e:local:ui": "tsx scripts/run-e2e.ts --app=ehr --ui",
+    "ehr:e2e:local:smoke": "SMOKE_TEST=true INTEGRATION_TEST=true tsx scripts/run-e2e.ts --app=ehr",
     "ehr:e2e:local:smoke:ui": "SMOKE_TEST=true INTEGRATION_TEST=true tsx scripts/run-e2e.ts --app=ehr --ui",
     "ehr:e2e:local:integration:ui": "INTEGRATION_TEST=true tsx scripts/run-e2e.ts --app=ehr --ui",
     "ehr:e2e:demo": "ENV=demo tsx scripts/run-e2e.ts --app=ehr",

scripts/run-e2e.ts

@@ -230,17 +230,22 @@ function createTestProcess(testType: 'login' | 'specs', appName: string): any {
   };
 
   const baseArgs = commands[testType];
-  const extraArgs = isUI ? [] : ['--', '--headed=false'];
+  const extraArgs: string[] = [];
+
+  // Only add --headed if we want headed mode (UI mode)
+  // By default Playwright runs headless, so we don't need to pass anything for headless
+  if (isUI) {
+    extraArgs.push('--headed');
+  }
 
   if (SMOKE_TEST === 'true' && testType !== 'login') {
     extraArgs.push('--grep', '@smoke');
   }
 
-  if (extraArgs.length > 0 && extraArgs[0] !== '--') {
-    extraArgs.unshift('--');
-  }
+  // Build the playwright args as an environment variable for turbo to pass through
+  const playwrightArgs = extraArgs.length > 0 ? extraArgs.join(' ') : '';
 
-  return spawn('turbo', [...baseArgs, ...extraArgs], {
+  return spawn('turbo', baseArgs, {
     shell: true,
     stdio: 'inherit',
     env: {
@@ -250,6 +255,7 @@ function createTestProcess(testType: 'login' | 'specs', appName: string): any {
       IS_LOGIN_TEST: testType === 'login' ? 'true' : 'false',
       ...(testType === 'specs' && { INTEGRATION_TEST }),
       SMOKE_TEST,
+      PLAYWRIGHT_EXTRA_ARGS: playwrightArgs,
     },
   });
 }