Skip to content

Show pip install error message to the user#40

Merged
maarzt merged 4 commits into
masterfrom
display-install-errors
Apr 17, 2026
Merged

Show pip install error message to the user#40
maarzt merged 4 commits into
masterfrom
display-install-errors

Conversation

@maarzt
Copy link
Copy Markdown
Collaborator

@maarzt maarzt commented Mar 18, 2026

The installation of the mastodon-blender-addon into Blender is not trivial.
Unfortunately error messages are currently not displayed if the user uses Blender Setup dialog.
This is now fixed pip output and GRPC output is shown if the installation fails.

maarzt added 2 commits March 18, 2026 15:26
This makes it easier for users to pinpoint fix and report problems.
The script previously ignored the stdout and stderr of pip and GRPC compilation.
Using subprocess.run() now forwards stdout and stderr to the console.
@maarzt maarzt requested a review from stefanhahmann March 18, 2026 14:44
@maarzt maarzt self-assigned this Mar 18, 2026
stefanhahmann
stefanhahmann previously approved these changes Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@stefanhahmann stefanhahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did mvn clean package with the code that is contained in this branch.

I then installed a fresh fiji stable with update sites mastodon, mastodon-blender activated.

I then tried to install the addon on MacOS.

I received this error message:

Image

While this is an error, I understand that the fact that Command, Exit Code, Command output and Command error are shown, is already the expected behaviour after this PR is merged.

I found a small typo and made some minor formatting suggestions. Other than that this PR is good to be merged.


As a side note: this repo would benefit from a multi-os CI pipeline similar to this one:

https://github.com/BioImageTools/ome-zarr-fiji-java/pull/59/changes#diff-88356dc1f81eb1c6fee09217f67c5cca712654df6def7bf3f1f594a85b1ca44f

This could result in these checks:

Image

Comment thread src/main/java/org/mastodon/blender/setup/BlenderSetupUtils.java Outdated
Comment thread src/main/java/org/mastodon/blender/setup/BlenderSetupUtils.java Outdated
Comment thread src/main/java/org/mastodon/blender/setup/BlenderSetupUtils.java Outdated
Comment thread src/main/java/org/mastodon/blender/setup/BlenderSetupUtils.java Outdated
maarzt added 2 commits April 17, 2026 17:08
Add an empty line after the first line of the error message.
…ation

The unit test for the error message formatting can run on github actions.
@maarzt maarzt merged commit a32fd51 into master Apr 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants