Skip to content

Commit c662332

Browse files
Merge pull request #130 from mastodon-sc/umap-1-dimension
Allow Umap with 1 target dimension
2 parents 1bbca04 + e1589dd commit c662332

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

src/main/java/org/mastodon/mamut/feature/branch/dimensionalityreduction/umap/BranchUmapFeature.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
*/
5050
public class BranchUmapFeature extends AbstractUmapFeature< BranchSpot >
5151
{
52-
public static final String KEY = "Branch Umap outputs";
52+
public static final String KEY = "Branch Umap output";
5353

5454
private final BranchSpotUmapFeatureSpec adaptedSpec;
5555

src/main/java/org/mastodon/mamut/feature/dimensionalityreduction/ui/DimensionalityReductionView.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ public class DimensionalityReductionView extends JFrame
117117

118118
private static final String PANEL_CONSTRAINTS = "span, growx, pushx, growy, pushy, wrap";
119119

120+
private static final int MINIMUM_NUMBER_OF_DIMENSIONS = 1;
121+
120122
public DimensionalityReductionView( final Model model, final Context context )
121123
{
122124
this.featureModel = model.getFeatureModel();
@@ -320,7 +322,7 @@ private SpinnerModel getNumberOfDimensionsSpinnerModel()
320322
{
321323
int maximumNumberOfDimensions = Math.max( 2, inputDimensionsPanel.getNumberOfFeatures() );
322324
int numberOfDimensions = Math.min( controller.getCommonSettings().getNumberOfOutputDimensions(), maximumNumberOfDimensions );
323-
return new SpinnerNumberModel( numberOfDimensions, CommonSettings.DEFAULT_NUMBER_OF_OUTPUT_DIMENSIONS,
325+
return new SpinnerNumberModel( numberOfDimensions, MINIMUM_NUMBER_OF_DIMENSIONS,
324326
maximumNumberOfDimensions, 1 );
325327
}
326328

src/main/java/org/mastodon/mamut/feature/spot/dimensionalityreduction/umap/SpotUmapFeature.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
*/
5050
public class SpotUmapFeature extends AbstractUmapFeature< Spot >
5151
{
52-
public static final String KEY = "Spot Umap outputs";
52+
public static final String KEY = "Spot Umap output";
5353

5454
private final SpotUmapFeatureSpec adaptedSpec;
5555

0 commit comments

Comments
 (0)