Use scijavas new custom labels feature for the config enums#55
Open
stefanhahmann wants to merge 4 commits into
Open
Use scijavas new custom labels feature for the config enums#55stefanhahmann wants to merge 4 commits into
stefanhahmann wants to merge 4 commits into
Conversation
stefanhahmann
force-pushed
the
enum-custom-labels
branch
9 times, most recently
from
f45f11b to
27debca
Compare
stefanhahmann
force-pushed
the
enum-custom-labels
branch
from
27debca to
5c63de2
Compare
added 4 commits
November 23, 2023 17:41
…od, CropCriteria and SimilarityMeasure
* LabelOptions.getByName() method is no longer needed
stefanhahmann
force-pushed
the
enum-custom-labels
branch
from
5c63de2 to
84c0994
Compare
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes use of the possibility that enum classes can now be directly used as parameters in SciJava Command views without the need for any getByName() methods in the enum classes.
Currently this comes with the disadvantage that such parameters will not be persisted as usual, i.e. when the Command View is shown repeatedly, it will always show the default parameters value and not the parameter values that had last been selected by the user.
For persistence of enum parameters, there exists an issue here: scijava/scijava-common#471