-
-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
Reviewed the repo, and here are some thoughts for improvements in no particular order:
- Remove RTK. It is overkill for state management imo, and we could easily just load saved accounts via vanilla React Context and
useEffect. If we do want to keep RTK, we should combine the reducer and actions into a slice. - This callback should leverage TSQ's
useMutationhook instead. - Move API calls to their own file instead of embedding them in components.
- We need to handle code signing for servers- my server
tech.lgbtdoesn't allow the web finger request. - Remove the extraneous
tsconfig- we have one for Node, but this only runs in the browser. - Prettier should be configured to work with ESLint.
- Move
?text=to#text=as URI fragments aren't sent to the server, which allows greater privacy. - Enable ESLint rules around import sorting, as I personally find mixing them all together rather confusing.
- Have consistent casing around filenames- some are all lowercase, some Pascal casing.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels