Skip to content

Potential improvements #1

@ChaosExAnima

Description

@ChaosExAnima

Reviewed the repo, and here are some thoughts for improvements in no particular order:

  • Remove RTK. It is overkill for state management imo, and we could easily just load saved accounts via vanilla React Context and useEffect. If we do want to keep RTK, we should combine the reducer and actions into a slice.
  • This callback should leverage TSQ's useMutation hook instead.
  • Move API calls to their own file instead of embedding them in components.
  • We need to handle code signing for servers- my server tech.lgbt doesn't allow the web finger request.
  • Remove the extraneous tsconfig- we have one for Node, but this only runs in the browser.
  • Prettier should be configured to work with ESLint.
  • Move ?text= to #text= as URI fragments aren't sent to the server, which allows greater privacy.
  • Enable ESLint rules around import sorting, as I personally find mixing them all together rather confusing.
  • Have consistent casing around filenames- some are all lowercase, some Pascal casing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions