[MaterialComponentsAndroid-MaterialDatePicker] Incorrect behaviour on Samsung device

[SmirnovDV-98]

On Samsung Galaxy S9 Api30 date picker component from demo application behaves totally incorrectly.

System information:

Text input works completely incorrectly, not applying text format and treating hint as simple text

Video of incorrect work attached:
https://github.com/material-components/material-components-android/assets/61781754/e6a7b812-2565-440b-80e5-c6c93a270054

[hunterstich]

Hi @SmirnovDV-98,

Could you describe what the expected behavior should be? I see the same behavior on my end running Android 14 on a Pixel but I think this is working as intended.

[SmirnovDV-98]

Greetings. In my opinion, expected behaviour would be the same as on my other phone, Xiaomi 9 Api30 (whole specification on attached screenshot), when input is restricted with numbers only, the hint is replaced exactly with inputed numbers, saving text format.

…

On Tue, 10 Oct 2023, 23:50 Hunter ***@***.***> wrote: Hi @SmirnovDV-98 <https://github.com/SmirnovDV-98>, Could you describe what the expected behavior should be? I see the same behavior on my end running Android 14 on a Pixel but I think this is working as intended. — Reply to this email directly, view it on GitHub <#3625 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOXLN6SS4CIIQWH5HYSPSQ3X6WYKJAVCNFSM6AAAAAA52O7JZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGIZDIMRQHA> . You are receiving this because you were mentioned.Message ID: <material-components/material-components-android/issues/3625/1756224208@ github.com>

[SmirnovDV-98]

video of expected behaviour

video_2023-10-11_08-17-29.mp4

video of expected behaviour

[hunterstich]

Ah, so the issue is the IME (keyboard) that shows on Samsung is the full alphanumeric keyboard instead of just the numeric keyboard?

[pubiqq]

Ah, so the issue is the IME (keyboard) that shows on Samsung is the full alphanumeric keyboard instead of just the numeric keyboard?

No, the issue is that the date field is automatically filled with the hint text when you enter a character:

Actual result	Expected result
video_2023-10-10_17-30-10.mp4	video_2023-10-11_08-17-29.mp4

[hunterstich]

Ah! Thanks for the clarification. And thanks for the PR @pubiqq.

#3628

[pubiqq]

Unfortunately, 5aa6edf is an unreliable hack, not a fix. It would be great if you would replace it with this this proposal.

[paulfthomas]

@pubiqq I don't think your fix properly accounts for all the different languages/international date patterns.

[pubiqq]

I don't think your fix properly accounts for all the different languages/international date patterns.

The current implementation doesn't do that either 😂.

My implementation is much better because it uses the actual date pattern and filters characters that are guaranteed to be delimiters, whereas the current implementation uses a decorative string (huh?) and filters all letters and digits in it (huh? x2).

As a result, my implementation works just as well as the current one, but it also:

• Works correctly with digits in the pattern.
• Works correctly with non-Latin letters in the pattern.
• Works correctly with Korean and some other languages (actually, I could even get rid of the hack related to the Korean language in this PR, but I'd like to do it a bit later in another one).

To account for all the different languages/international date patterns, we will also need to implement the correct handling of single quotation marks, but personally I will be ready to do this only after the DateFormatTextWatcher is fixed.