Skip to content
This repository was archived by the owner on Dec 11, 2025. It is now read-only.

Commit 9d240ba

Browse files
author
Jeff Verkoeyen
committed
1.0.0 release bugfix.
Summary: The 1.0.0 release included the following warning: components/Switch/src/MDCSwitch.m:223:11: error: parameter 'toggleState' not found in the function declaration [-Werror,-Wdocumentation] This was resolved in `develop`, so we're back-porting the fix to the 1.0.0 release. Cherry-picked from http://codereview.cc/D204: [Switch] Remove internal docs demarcated with /**. Reviewers: ajsecord, randallli, #mdc_ios_owners, iangordon Reviewed By: #mdc_ios_owners, iangordon Projects: #material_components_ios Differential Revision: http://codereview.cc/D212
1 parent 1827d1c commit 9d240ba

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
## In progress since last release
1+
## 1.0.1
22

3-
##### Breaking
43
##### Enhancements
5-
##### Bug Fixes
4+
5+
* [Switch] Removed internal docs that were pretending to be public docs. [Jeff Verkoeyen](https://github.com/jverkoey)
66

77
## 1.0.0
88

components/Switch/src/MDCSwitch.m

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,6 @@ - (void)thumbTrack:(MDCThumbTrack *)thumbTrack willJumpToValue:(CGFloat)value {
218218
[self updateAccessibilityValues];
219219
}
220220

221-
/**
222-
* Updates the accessibility value of the switch given a toggle state.
223-
* @param toggleState A value for the state of the switch.
224-
*/
225221
- (void)updateAccessibilityValues {
226222
// Set accessibility value similar to native UISwitch.
227223
if (self.on) {
@@ -239,11 +235,6 @@ - (void)updateAccessibilityValues {
239235
}
240236
}
241237

242-
/**
243-
* Returns the toggle state of the switch given a possible slider @c value on the @c thumbTrack.
244-
* @param thumbTrack The contained @c MDCThumbTrack object.
245-
* @param value The value of the slider in @c thumbTrack.
246-
*/
247238
- (BOOL)toggleStateFromThumbTrack:(MDCThumbTrack *)thumbTrack withValue:(CGFloat)value {
248239
// TODO(ajsecord): When the track supports multiple discrete locations, get the location directly.
249240
BOOL allSignsPointToYes = value >= (thumbTrack.minimumValue + thumbTrack.maximumValue) / 2;

0 commit comments

Comments
 (0)