Add CI checks with GC disabled

add workaround for the apple compiler saying `__ARM_FEATURE_DOTPROD` is
supported when it is not.

Signed-off-by: Máté Tokodi [email protected]

Author: matetokodi

.github/workflows/actions.yml

@@ -362,6 +362,70 @@ jobs:
         run: |
           $RUNNER --engine="$GITHUB_WORKSPACE/out/extended/walrus" ${{ matrix.switch }} wasm-test-extended
 
+  build-test-no-gc-linux:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        mode: [debug]
+        arch: [x64]
+        switch: [--jit, ""]
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: true
+      - name: Install Packages
+        run: |
+          sudo apt update
+          sudo apt install -y ninja-build gcc-multilib g++-multilib
+      - name: Build ${{ matrix.arch}}
+        env:
+          BUILD_OPTIONS: -DWALRUS_ARCH=${{ matrix.arch }} -DWALRUS_HOST=linux -DWALRUS_MODE=${{ matrix.mode }} -DWALRUS_OUTPUT=shell -DWALRUS_GC=OFF -GNinja
+        run: |
+          cmake -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -H. -Bout/nogc $BUILD_OPTIONS
+          ninja -Cout/nogc
+      - name: "Remove GC tests"
+        run: |
+          rm -rf ./test/web-assembly3/gc
+      - name: Run Tests
+        run: |
+          $RUNNER --engine="$GITHUB_WORKSPACE/out/nogc/walrus" ${{ matrix.switch }}
+
+  build-test-no-gc-on-macos-arm64:
+    strategy:
+      fail-fast: false
+      matrix:
+        mode: [debug]
+        switch: [--jit, ""]
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: true
+      - name: Install Packages
+        run: |
+          brew update
+          brew install ninja
+      - name: Build arm64
+        env:
+          BUILD_OPTIONS: -DWALRUS_MODE=${{ matrix.mode }} -DWALRUS_OUTPUT=shell -DWALRUS_GC=OFF -GNinja
+        run: |
+          cmake -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -H. -Bout/mac $BUILD_OPTIONS
+          ninja -Cout/mac
+      - name: "Remove 2 test files due to stack overflow occurred by recursion calls in debug mode build by clang"
+        if: matrix.mode == 'debug'
+        run: |
+          rm ./test/wasm-spec/core/call.wast
+          rm ./test/wasm-spec/core/call_indirect.wast
+      - name: "Remove GC tests"
+        run: |
+          rm -rf ./test/extended/gc
+      - name: Run Tests
+        run: |
+          #FIXME try-catch is unstable in macos build
+          $RUNNER --engine="$GITHUB_WORKSPACE/out/mac/walrus" ${{ matrix.switch }}
+
+
   build-test-performance-x64_x86:
     strategy:
       fail-fast: false

build/target.cmake

@@ -187,6 +187,7 @@ ELSEIF (${WALRUS_HOST} STREQUAL "darwin")
     SET (WALRUS_THIRDPARTY_CFLAGS ${WALRUS_THIRDPARTY_CFLAGS} -UHAVE_PTHREAD_GETATTR_NP -UUSE_GET_STACKBASE_FOR_MAIN)
     SET (WALRUS_BUILD_64BIT ON)
     SET (WALRUS_BUILD_64BIT_LARGE ON)
+    add_compile_definitions(WALRUS_APPLE)
 ELSEIF (${WALRUS_HOST} STREQUAL "windows")
     # in windows, default stack limit is 1MB
     # but expand stack to 8MB when building to exe for running test
@@ -212,6 +213,7 @@ ELSEIF (${WALRUS_HOST} STREQUAL "windows")
     ELSE()
         MESSAGE (FATAL_ERROR ${WALRUS_ARCH} " is unsupported")
     ENDIF()
+
 ELSE()
     MESSAGE (FATAL_ERROR ${WALRUS_HOST} " with " ${WALRUS_ARCH} " is unsupported")
 ENDIF()

src/jit/SimdArm64Inl.h

@@ -605,7 +605,7 @@ static void simdEmitNarrowUnsigned(sljit_compiler* compiler, sljit_s32 rd, sljit
 static void simdEmitDot(sljit_compiler* compiler, uint32_t type, sljit_s32 rd, sljit_s32 rn, sljit_s32 rm)
 {
     // The rd can be tmpReg1
-#ifdef __ARM_FEATURE_DOTPROD
+#if defined(__ARM_FEATURE_DOTPROD) && !defined(WALRUS_APPLE)
     simdEmitOp(compiler, SimdOp::sdot | type, rd, rn, rm);
 #else
     sljit_s32 tmpReg1 = SLJIT_TMP_FR0;