Skip to content

Wrong implementation of the EIP712 signatures #143

Open
@irux

Description

Hello, I am having problems to make EIP3009 from usdc polygon pos to work and it seems it uses the contracts from this repo.

It seems the EIP712 is wrong implemented: https://github.com/maticnetwork/pos-portal/blob/master/contracts/common/EIP712Base.sol#L36

First, the order from the domain separator should be in the order they give you here: https://eips.ethereum.org/EIPS/eip-712

Moreover the calculation of the EIP712_DOMAIN_TYPEHASH is wrong. We are using salt but we are not encoding any salt at all. EIP712Domain(string name,string version,address verifyingContract,bytes32 salt) this gives problems when you want to calculate the signature with standards like signTypedData from metamask.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions