Skip to content

Commit 4ce8179

Browse files
sgiehltzi
andauthored
Apply suggestions from code review
Co-authored-by: Thomas ZILLIOX <[email protected]>
1 parent 5e516bd commit 4ce8179

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

core/Twig.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function piwik_filter_truncate($string, $size)
4646
* @param string $string
4747
* @param int $minFractionDigits
4848
* @param int $maxFractionDigits
49-
* @return float|int|mixed|string
49+
* @return mixed
5050
*/
5151
function piwik_format_number($string, $minFractionDigits, $maxFractionDigits)
5252
{
@@ -252,7 +252,7 @@ protected function addFunctionIncludeAssets(): void
252252
}
253253

254254
$assetType = strtolower($params['type']);
255-
$deferJs = boolval($params['defer'] ?? false);
255+
$deferJs = boolval($params['defer'] ?? false);
256256
switch ($assetType) {
257257
case 'css':
258258
return AssetManager::getInstance()->getCssInclusionDirective();
@@ -556,8 +556,7 @@ protected function addFilterUrlRewriteWithParameters(): void
556556
{
557557
$urlRewriteFilter = new TwigFilter('urlRewriteWithParameters', function ($parameters) {
558558
$parameters['updated'] = null;
559-
$url = Url::getCurrentQueryStringWithParametersModified($parameters);
560-
return $url;
559+
return Url::getCurrentQueryStringWithParametersModified($parameters);
561560
});
562561
$this->twig->addFilter($urlRewriteFilter);
563562
}

plugins/Intl/DateTimeFormatProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function __construct(Translator $translator)
3232
/**
3333
* Returns the format pattern for the given format type
3434
*
35-
* @param int|string $format one of the format constants
35+
* @param int|string $format one of the format constants
3636
*
3737
* @return string
3838
*/

0 commit comments

Comments
 (0)